Source/core/frame/Console.cpp - Issue 206093005: Oilpan: move Console objects to the oilpan heap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/frame/Console.cpp

Issue 206093005: Oilpan: move Console objects to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/frame/Console.h ('k') | Source/core/frame/ConsoleBase.h » ('j') | Source/core/frame/ConsoleBase.h » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2007 Apple Inc. All rights reserved.	2 * Copyright (C) 2007 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 65 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
76 m_frame->host()->chrome().client().addMessageToConsole(ConsoleAPIMessageSour ce, level, message, callStack->at(0).lineNumber(), callStack->at(0).sourceURL(), stackTrace);	76 m_frame->host()->chrome().client().addMessageToConsole(ConsoleAPIMessageSour ce, level, message, callStack->at(0).lineNumber(), callStack->at(0).sourceURL(), stackTrace);

77 }	77 }

78	78

79 PassRefPtrWillBeRawPtr<MemoryInfo> Console::memory() const	79 PassRefPtrWillBeRawPtr<MemoryInfo> Console::memory() const

80 {	80 {

81 // FIXME: Because we create a new object here each time,	81 // FIXME: Because we create a new object here each time,

82 // console.memory !== console.memory, which seems wrong.	82 // console.memory !== console.memory, which seems wrong.

83 return MemoryInfo::create(m_frame);	83 return MemoryInfo::create(m_frame);

84 }	84 }

85	85

	86 void Console::trace(Visitor* visitor)

	87 {

	88 ConsoleBase::trace(visitor);

	89 }

	90

86 } // namespace WebCore	91 } // namespace WebCore

OLD	NEW