Issue 206093004: Modify condition for fixedToRight and fixedToBottom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206093004: Modify condition for fixedToRight and fixedToBottom

Created:
6 years, 9 months ago by Kyungtae Kim

Modified:
6 years, 5 months ago

Reviewers:
Inactive

CC:
blink-reviews, blink-layers+watch_chromium.org, kenneth.christiansen

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Modify condition for fixedToRight and fixedToBottom Currently, the position for fixed elements are adjusted during zooming, especially for the fixedToRight or the fixedToBottom elements. However, the position for the elements with both the right and left or both the top and bottom are mistakenly adjuste d, because that elements are not fixedToRight or the fixedToBottom. So, to check the fixedToRight or fixedToBottom, left or top also need to be checked. BUG=354398

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/page/scrolling/ScrollingCoordinator.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Inactive

On 2014/03/20 12:12:46, Kyungtae Kim wrote: > PTAL This needs a layout test.

6 years, 6 months ago (2014-06-11 11:23:20 UTC) #2

Inactive

On 2014/06/11 11:23:20, Chris Dumez wrote: > On 2014/03/20 12:12:46, Kyungtae Kim wrote: > > ...

6 years, 6 months ago (2014-06-11 11:27:36 UTC) #3

Kyungtae Kim

6 years, 5 months ago (2014-07-21 02:55:47 UTC) #5

On 2014/06/11 11:27:36, Chris Dumez wrote:
> On 2014/06/11 11:23:20, Chris Dumez wrote:
> > On 2014/03/20 12:12:46, Kyungtae Kim wrote:
> > > PTAL
> > 
> > This needs a layout test.
> 
> Once you have a layout test, you should probably add morrita@ and rbyers@ as
> reviewers.

Because the adjust action only affect the temporal position during zooming, this
code could not affect the layout test result.
Is there some special layout tests for the cases like this?

Expand Messages | Collapse Messages