chrome/browser/download/chrome_download_manager_delegate.h - Issue 2060923002: Neutralize dangerous subresource files during Save Page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/chrome_download_manager_delegate.h

Issue 2060923002: Neutralize dangerous subresource files during Save Page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@save-package-cleanup-1

Patch Set: Add a DCHECK to verify that sanitization doesn't affect containing directory. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/download/chrome_download_manager_delegate.cc » ('j') | chrome/browser/download/chrome_download_manager_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/chrome_download_manager_delegate.h

diff --git a/chrome/browser/download/chrome_download_manager_delegate.h b/chrome/browser/download/chrome_download_manager_delegate.h

index 04e2540bcaf66f215dd278149fe89aff58be0a22..23e0787ca317d79e860bd3319579f03a4c69fc93 100644

--- a/chrome/browser/download/chrome_download_manager_delegate.h

+++ b/chrome/browser/download/chrome_download_manager_delegate.h

@@ -80,6 +80,7 @@ class ChromeDownloadManagerDelegate

const base::FilePath::StringType& default_extension,

bool can_save_as_complete,

const content::SavePackagePathPickedCallback& callback) override;

+ void SanitizeSaveItemFilename(base::FilePath* filename) override;

void OpenDownload(content::DownloadItem* download) override;

void ShowDownloadInShell(content::DownloadItem* download) override;

void CheckForFileExistence(

« no previous file with comments | « no previous file | chrome/browser/download/chrome_download_manager_delegate.cc » ('j') | chrome/browser/download/chrome_download_manager_delegate.cc » ('J')