content/browser/download/save_package.h - Issue 2060923002: Neutralize dangerous subresource files during Save Page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/save_package.h

Issue 2060923002: Neutralize dangerous subresource files during Save Page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@save-package-cleanup-1

Patch Set: Catch up with ToT Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/download/save_package.h

diff --git a/content/browser/download/save_package.h b/content/browser/download/save_package.h

index 0161616fbf0a2158bb48da86d371caaf9b186102..edc54841c8ef1c7017d7a0806c525d0b315c2e94 100644

--- a/content/browser/download/save_package.h

+++ b/content/browser/download/save_package.h

@@ -208,7 +208,7 @@ class CONTENT_EXPORT SavePackage

// Returns true if |base_name| could be successfully adjusted to fit the

// aforementioned constraints, or false otherwise.

- // TODO(asanka): This funciton is wrong. |base_name| cannot be truncated

+ // TODO(asanka): This function is wrong. |base_name| cannot be truncated

// without knowing its encoding and truncation has to be performed on

// character boundaries. Also the implementation doesn't look up the actual

// path constraints and instead uses hard coded constants. crbug.com/618737

« no previous file with comments | « chrome/test/data/save_page/not-a-crx.crx.mock-http-headers ('k') | content/browser/download/save_package.cc » ('j') | no next file with comments »