chrome/browser/resources/safe_browsing/README.md - Issue 2060923002: Neutralize dangerous subresource files during Save Page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/safe_browsing/README.md

Issue 2060923002: Neutralize dangerous subresource files during Save Page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@save-package-cleanup-1

Patch Set: Catch up with ToT Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/safe_browsing/README.md

diff --git a/chrome/browser/resources/safe_browsing/README.md b/chrome/browser/resources/safe_browsing/README.md

index 7b85908bbede9bb56d79c942568fa8db014332aa..c745b96717105ad0e1f6fd0e5caf61822d0f1998 100644

--- a/chrome/browser/resources/safe_browsing/README.md

+++ b/chrome/browser/resources/safe_browsing/README.md

@@ -77,6 +77,12 @@ See `download_file_types.proto` for all fields.

`DANGEROUS_HOST`, or `DANGEROUS`, Chrome will show that more severe warning

regardless of this setting.

+ This policy also affects also how subresources are handled for *"Save As

+ ..."* downloads of complete web pages. If any subresource ends up with a

+ file type that is considered `DANGEROUS` or `ALLOW_ON_USER_GESTURE`, then

+ the filename will be changed to end in `.download`. This is done to prevent

+ the file from being opened accidentally.

* `NOT_DANGEROUS`: Safe to download and open, even if the download

was accidental. No additional warnings are necessary.

* `DANGEROUS`: Always warn the user that this file may harm their

« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | chrome/test/data/save_page/dubious-subresources.html » ('j') | no next file with comments »