Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2703)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/safe_browsing/README.md

Issue 2060923002: Neutralize dangerous subresource files during Save Page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@save-package-cleanup-1
Patch Set: Reword note in README.md Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | chrome/test/data/save_page/dubious-subresources.html » ('j') | content/public/browser/download_manager_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/safe_browsing/README.md
diff --git a/chrome/browser/resources/safe_browsing/README.md b/chrome/browser/resources/safe_browsing/README.md
index d61aafff67c4d23b8dea5dddb84a0be33e5b5ccf..ee761353bdb7c9cf182796b235ba815166043a33 100644
--- a/chrome/browser/resources/safe_browsing/README.md
+++ b/chrome/browser/resources/safe_browsing/README.md
@@ -66,6 +66,15 @@ See `download_file_types.proto` for all fields.
3. The `default_file_type`'s settings will be filled in.
* `platform_settings.danger_level`: (required)
+ Note that this policy affects how individual file downloads are handled as
+ well as how subresources are handled for *"Save As ..."* downloads of
+ complete web pages.
+
+ For *"Save As ..."* downloads, if any subresource ends up with a file type
+ that is considered `DANGEROUS` or `ALLOW_ON_USER_GESTURE`, then the filename
+ will be changed to end in `.download`. This is done to prevent the file from
+ being opened accidentally.
+
* `NOT_DANGEROUS`: Safe to download and open, even if the download
was accidental.
* `DANGEROUS`: Always warn the user that this file may harm their
« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | chrome/test/data/save_page/dubious-subresources.html » ('j') | content/public/browser/download_manager_delegate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698