Make code compile with clang_use_chrome_plugin (part II)

Make code compile with clang_use_chrome_plugin (part II)

This change contains files in core directory which were not covered
in part I. This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;

BUG=pdfium:469
Committed: https://pdfium.googlesource.com/pdfium/+/f4bb580add3824196dc49cd7de2f7d051019ede8

[Wei Li, 2016-06-13 20:23:51]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-06-14 06:02:30]

Patchset #2 (id:40001) has been deleted

[Wei Li, 2016-06-14 17:07:44]

Patchset #1 (id:20001) has been deleted

[Wei Li, 2016-06-14 17:07:56]

Patchset #1 (id:60001) has been deleted

[Wei Li, 2016-06-14 17:08:06]

Patchset #1 (id:80001) has been deleted

[Wei Li, 2016-06-14 17:08:16]

Patchset #1 (id:100001) has been deleted

[Wei Li, 2016-06-14 17:08:24]

Patchset #1 (id:120001) has been deleted

[Wei Li, 2016-06-14 17:08:33]

Patchset #1 (id:140001) has been deleted

[Wei Li, 2016-06-14 19:35:34]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-06-14 19:35:36]

Pls review, thanks.

https://codereview.chromium.org/2060913003/diff/160001/core/fpdfdoc/clines.h
File core/fpdfdoc/clines.h (right):

https://codereview.chromium.org/2060913003/diff/160001/core/fpdfdoc/clines.h#...
core/fpdfdoc/clines.h:12: class CLines final {
Separated from pdf_vt.h

https://codereview.chromium.org/2060913003/diff/160001/core/fxge/ge/fx_text_i...
File core/fxge/ge/fx_text_int.h (left):

https://codereview.chromium.org/2060913003/diff/160001/core/fxge/ge/fx_text_i...
core/fxge/ge/fx_text_int.h:26: class CTTFontDesc {
moved these to fx_font.h

[dsinclair, 2016-06-14 20:12:48]

lgtm w/ nits.

https://codereview.chromium.org/2060913003/diff/200001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2060913003/diff/200001/BUILD.gn#newcode198
BUILD.gn:198: "core/fpdfdoc/clines.cpp",
add "core/fpdfdoc/clines.h",

https://codereview.chromium.org/2060913003/diff/200001/core/fpdfdoc/clines.cpp
File core/fpdfdoc/clines.cpp (right):

https://codereview.chromium.org/2060913003/diff/200001/core/fpdfdoc/clines.cp...
core/fpdfdoc/clines.cpp:30: }
nit: no {}'s

https://codereview.chromium.org/2060913003/diff/200001/core/fpdfdoc/clines.h
File core/fpdfdoc/clines.h (right):

https://codereview.chromium.org/2060913003/diff/200001/core/fpdfdoc/clines.h#...
core/fpdfdoc/clines.h:29: #endif  // CORE_FPDFDOC_CLINES_H_
nit: blank line before #endif

https://codereview.chromium.org/2060913003/diff/200001/core/fpdfdoc/doc_tagge...
File core/fpdfdoc/doc_tagged.cpp (right):

https://codereview.chromium.org/2060913003/diff/200001/core/fpdfdoc/doc_tagge...
core/fpdfdoc/doc_tagged.cpp:211: // IPDF_StructElement
I don't think we typically mark override sections in the .cpp files? (Or do we
and I missed it?)

https://codereview.chromium.org/2060913003/diff/200001/pdfium.gyp
File pdfium.gyp (right):

https://codereview.chromium.org/2060913003/diff/200001/pdfium.gyp#newcode215
pdfium.gyp:215: 'core/fpdfdoc/clines.cpp',
nit: add clines.h

[Lei Zhang, 2016-06-14 20:33:07]

lgtm

[Wei Li, 2016-06-14 22:00:54]

thanks

https://codereview.chromium.org/2060913003/diff/200001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2060913003/diff/200001/BUILD.gn#newcode198
BUILD.gn:198: "core/fpdfdoc/clines.cpp",
On 2016/06/14 20:12:48, dsinclair wrote:
> add "core/fpdfdoc/clines.h",

Done.

https://codereview.chromium.org/2060913003/diff/200001/core/fpdfdoc/clines.cpp
File core/fpdfdoc/clines.cpp (right):

https://codereview.chromium.org/2060913003/diff/200001/core/fpdfdoc/clines.cp...
core/fpdfdoc/clines.cpp:30: }
On 2016/06/14 20:12:48, dsinclair wrote:
> nit: no {}'s

Done.

https://codereview.chromium.org/2060913003/diff/200001/core/fpdfdoc/clines.h
File core/fpdfdoc/clines.h (right):

https://codereview.chromium.org/2060913003/diff/200001/core/fpdfdoc/clines.h#...
core/fpdfdoc/clines.h:29: #endif  // CORE_FPDFDOC_CLINES_H_
On 2016/06/14 20:12:48, dsinclair wrote:
> nit: blank line before #endif

Done.

https://codereview.chromium.org/2060913003/diff/200001/core/fpdfdoc/doc_tagge...
File core/fpdfdoc/doc_tagged.cpp (right):

https://codereview.chromium.org/2060913003/diff/200001/core/fpdfdoc/doc_tagge...
core/fpdfdoc/doc_tagged.cpp:211: // IPDF_StructElement
On 2016/06/14 20:12:48, dsinclair wrote:
> I don't think we typically mark override sections in the .cpp files? (Or do we
> and I missed it?)

Done.

https://codereview.chromium.org/2060913003/diff/200001/pdfium.gyp
File pdfium.gyp (right):

https://codereview.chromium.org/2060913003/diff/200001/pdfium.gyp#newcode215
pdfium.gyp:215: 'core/fpdfdoc/clines.cpp',
On 2016/06/14 20:12:48, dsinclair wrote:
> nit: add clines.h

Done.

[Wei Li, 2016-06-14 23:08:01]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-06-14 23:08:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2060913003/#ps240001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-14 23:08:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060913003/240001

[commit-bot: I haz the power, 2016-06-15 00:21:19]

Description was changed from

==========
Make code compile with clang_use_chrome_plugin (part II)

This change contains files in core directory which were not covered
in part I. This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;

BUG=pdfium:469
==========

to

==========
Make code compile with clang_use_chrome_plugin (part II)

This change contains files in core directory which were not covered
in part I. This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;

BUG=pdfium:469

Committed:
https://pdfium.googlesource.com/pdfium/+/f4bb580add3824196dc49cd7de2f7d051019...
==========

[commit-bot: I haz the power, 2016-06-15 00:21:21]

Committed patchset #5 (id:240001) as
https://pdfium.googlesource.com/pdfium/+/f4bb580add3824196dc49cd7de2f7d051019...

[caryclark, 2016-06-15 17:03:31]

caryclark@google.com changed reviewers:
+ caryclark@google.com

[caryclark, 2016-06-15 17:03:32]

This change broke Skia. I'll put together a CL to fix it.