Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2060903002:
Add SampleApp that shows problems in stroking (Closed)
|
Created:
4 years, 6 months ago by Harry Stern Modified:
4 years, 6 months ago Reviewers:
reed1 CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionAdd SampleApp that shows problems in stroking
- When the stroke width gets too big the raster algorithm produces
incorrect output
- This also causes the GPU path to produce incorrect output if the width
is larger than an arbitrary limit in GrAALinearizingConvexPathRenderer
(which is the renderer used for this specific geometry)
- Other non-convex geometries probably also produce strange results
BUG=skia:5405, skia:5406
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2060903002
Committed: https://skia.googlesource.com/skia/+/9bd4c693020bb440464ae12ae05e8e8f97568ee0
Patch Set 1 #Patch Set 2 : Use cmath instead of math.h #Patch Set 3 : Use SK_ScalarPI instead of having to do some weird define for windows #Patch Set 4 : Change things to explicitly be floats to appease Windows #Patch Set 5 : Run clang-format on SamplePathOverstroke.cpp #
Messages
Total messages: 26 (13 generated)
Description was changed from ========== Add SampleApp that shows problems in stroking - When the stroke width gets too big the raster algorithm produces incorrect output - This also causes the GPU path to produce incorrect output if the width is larger than an arbitrary limit in GrAALinearizingConvexPathRenderer (which is the renderer used for this specific geometry) - Other non-convex geometries probably also produce strange results BUG=skia:5405,5406 ========== to ========== Add SampleApp that shows problems in stroking - When the stroke width gets too big the raster algorithm produces incorrect output - This also causes the GPU path to produce incorrect output if the width is larger than an arbitrary limit in GrAALinearizingConvexPathRenderer (which is the renderer used for this specific geometry) - Other non-convex geometries probably also produce strange results BUG=skia:5405,5406 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2060903002 ==========
Description was changed from ========== Add SampleApp that shows problems in stroking - When the stroke width gets too big the raster algorithm produces incorrect output - This also causes the GPU path to produce incorrect output if the width is larger than an arbitrary limit in GrAALinearizingConvexPathRenderer (which is the renderer used for this specific geometry) - Other non-convex geometries probably also produce strange results BUG=skia:5405,5406 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2060903002 ========== to ========== Add SampleApp that shows problems in stroking - When the stroke width gets too big the raster algorithm produces incorrect output - This also causes the GPU path to produce incorrect output if the width is larger than an arbitrary limit in GrAALinearizingConvexPathRenderer (which is the renderer used for this specific geometry) - Other non-convex geometries probably also produce strange results BUG=skia:5405,5406 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2060903002 ==========
hstern@google.com changed reviewers: + reed@google.com
Description was changed from ========== Add SampleApp that shows problems in stroking - When the stroke width gets too big the raster algorithm produces incorrect output - This also causes the GPU path to produce incorrect output if the width is larger than an arbitrary limit in GrAALinearizingConvexPathRenderer (which is the renderer used for this specific geometry) - Other non-convex geometries probably also produce strange results BUG=skia:5405,5406 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2060903002 ========== to ========== Add SampleApp that shows problems in stroking - When the stroke width gets too big the raster algorithm produces incorrect output - This also causes the GPU path to produce incorrect output if the width is larger than an arbitrary limit in GrAALinearizingConvexPathRenderer (which is the renderer used for this specific geometry) - Other non-convex geometries probably also produce strange results BUG=skia:5405,skia:5406 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2060903002 ==========
lgtm
The CQ bit was checked by hstern@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060903002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
The CQ bit was checked by hstern@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060903002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
I probably need a new lgtm now that I made some changes, though all the trybots now pass.
lgtm
The CQ bit was checked by hstern@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060903002/80001
Sorry, one more after the trybots run (probably unnecessary). I will remember to run clang-format before asking for a review next time.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hstern@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com Link to the patchset: https://codereview.chromium.org/2060903002/#ps80001 (title: "Run clang-format on SamplePathOverstroke.cpp")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060903002/80001
Message was sent while issue was closed.
Description was changed from ========== Add SampleApp that shows problems in stroking - When the stroke width gets too big the raster algorithm produces incorrect output - This also causes the GPU path to produce incorrect output if the width is larger than an arbitrary limit in GrAALinearizingConvexPathRenderer (which is the renderer used for this specific geometry) - Other non-convex geometries probably also produce strange results BUG=skia:5405,skia:5406 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2060903002 ========== to ========== Add SampleApp that shows problems in stroking - When the stroke width gets too big the raster algorithm produces incorrect output - This also causes the GPU path to produce incorrect output if the width is larger than an arbitrary limit in GrAALinearizingConvexPathRenderer (which is the renderer used for this specific geometry) - Other non-convex geometries probably also produce strange results BUG=skia:5405,skia:5406 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2060903002 Committed: https://skia.googlesource.com/skia/+/9bd4c693020bb440464ae12ae05e8e8f97568ee0 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/9bd4c693020bb440464ae12ae05e8e8f97568ee0 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
