Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: chrome/browser/chromeos/drive/job_scheduler.cc

Issue 20609006: Add severity info to drive::EventLogger. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase - the 2nd try - Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/drive/drive_integration_service.cc ('k') | chrome/browser/chromeos/drive/logging.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/drive/job_scheduler.cc
diff --git a/chrome/browser/chromeos/drive/job_scheduler.cc b/chrome/browser/chromeos/drive/job_scheduler.cc
index 833765e59e3645aaa7d782144542a27a7474b5e3..4028164845ea81cadadd79917bfbc1642193858e 100644
--- a/chrome/browser/chromeos/drive/job_scheduler.cc
+++ b/chrome/browser/chromeos/drive/job_scheduler.cc
@@ -695,7 +695,8 @@ void JobScheduler::QueueJob(JobID job_id) {
const std::string retry_prefix = job_entry->retry_count > 0 ?
base::StringPrintf(" (retry %d)", job_entry->retry_count) : "";
- util::Log("Job queued%s: %s - %s",
+ util::Log(logging::LOG_INFO,
+ "Job queued%s: %s - %s",
retry_prefix.c_str(),
job_info.ToString().c_str(),
GetQueueInfo(queue_type).c_str());
@@ -732,7 +733,8 @@ void JobScheduler::DoJobLoop(QueueType queue_type) {
entry->cancel_callback = entry->task.Run();
- util::Log("Job started: %s - %s",
+ util::Log(logging::LOG_INFO,
+ "Job started: %s - %s",
job_info->ToString().c_str(),
GetQueueInfo(queue_type).c_str());
}
@@ -810,7 +812,9 @@ bool JobScheduler::OnJobDone(JobID job_id, google_apis::GDataErrorCode error) {
queue_[queue_type]->MarkFinished(job_id);
const base::TimeDelta elapsed = base::Time::Now() - job_info->start_time;
- util::Log("Job done: %s => %s (elapsed time: %sms) - %s",
+ bool success = (GDataToFileError(error) == FILE_ERROR_OK);
+ util::Log(success ? logging::LOG_INFO : logging::LOG_WARNING,
+ "Job done: %s => %s (elapsed time: %sms) - %s",
job_info->ToString().c_str(),
GDataErrorCodeToString(error).c_str(),
base::Int64ToString(elapsed.InMilliseconds()).c_str(),
@@ -1019,7 +1023,8 @@ void JobScheduler::AbortNotRunningJob(JobEntry* job,
const base::TimeDelta elapsed = base::Time::Now() - job->job_info.start_time;
const QueueType queue_type = GetJobQueueType(job->job_info.job_type);
- util::Log("Job aborted: %s => %s (elapsed time: %sms) - %s",
+ util::Log(logging::LOG_INFO,
+ "Job aborted: %s => %s (elapsed time: %sms) - %s",
job->job_info.ToString().c_str(),
GDataErrorCodeToString(error).c_str(),
base::Int64ToString(elapsed.InMilliseconds()).c_str(),
« no previous file with comments | « chrome/browser/chromeos/drive/drive_integration_service.cc ('k') | chrome/browser/chromeos/drive/logging.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698