Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: chrome/browser/chromeos/drive/job_scheduler.cc

Issue 20609006: Add severity info to drive::EventLogger. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/drive/job_scheduler.cc
diff --git a/chrome/browser/chromeos/drive/job_scheduler.cc b/chrome/browser/chromeos/drive/job_scheduler.cc
index 5ea3bd2b274e0dd473c5d18884d60f3e51765eae..0903173b5de432c5ef3d47b3f4c01d4dac302774 100644
--- a/chrome/browser/chromeos/drive/job_scheduler.cc
+++ b/chrome/browser/chromeos/drive/job_scheduler.cc
@@ -692,7 +692,9 @@ void JobScheduler::QueueJob(JobID job_id) {
QueueType queue_type = GetJobQueueType(job_info.job_type);
queue_[queue_type]->Push(job_id, job_entry->context.type);
- util::Log("Job queued: %s - %s", job_info.ToString().c_str(),
+ util::Log(logging::LOG_INFO,
+ "Job queued: %s - %s",
+ job_info.ToString().c_str(),
GetQueueInfo(queue_type).c_str());
}
@@ -727,7 +729,8 @@ void JobScheduler::DoJobLoop(QueueType queue_type) {
entry->cancel_callback = entry->task.Run();
- util::Log("Job started: %s - %s",
+ util::Log(logging::LOG_INFO,
+ "Job started: %s - %s",
job_info->ToString().c_str(),
GetQueueInfo(queue_type).c_str());
}
@@ -805,7 +808,9 @@ bool JobScheduler::OnJobDone(JobID job_id, google_apis::GDataErrorCode error) {
queue_[queue_type]->MarkFinished(job_id);
const base::TimeDelta elapsed = base::Time::Now() - job_info->start_time;
- util::Log("Job done: %s => %s (elapsed time: %sms) - %s",
+ bool success = (GDataToFileError(error) == FILE_ERROR_OK);
+ util::Log(success ? logging::LOG_INFO : logging::LOG_WARNING,
+ "Job done: %s => %s (elapsed time: %sms) - %s",
job_info->ToString().c_str(),
GDataErrorCodeToString(error).c_str(),
base::Int64ToString(elapsed.InMilliseconds()).c_str(),
@@ -1014,7 +1019,8 @@ void JobScheduler::AbortNotRunningJob(JobEntry* job,
const base::TimeDelta elapsed = base::Time::Now() - job->job_info.start_time;
const QueueType queue_type = GetJobQueueType(job->job_info.job_type);
- util::Log("Job aborted: %s => %s (elapsed time: %sms) - %s",
+ util::Log(logging::LOG_INFO,
+ "Job aborted: %s => %s (elapsed time: %sms) - %s",
job->job_info.ToString().c_str(),
GDataErrorCodeToString(error).c_str(),
base::Int64ToString(elapsed.InMilliseconds()).c_str(),

Powered by Google App Engine
This is Rietveld 408576698