Issue 20609006: Add severity info to drive::EventLogger.

Issue 20609006: Add severity info to drive::EventLogger. (Closed)

Created:
7 years, 4 months ago by kinaba

Modified:
7 years, 4 months ago

Reviewers:
hashimoto, tzik

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tfarina, rginda+watch_chromium.org, oshima+watch_chromium.org, tzik+watch_chromium.org, nhiroki+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add severity info to drive::EventLogger. This patch only changes the internal data that is stored. Interface change for drive-internals will come in a separate patch. BUG=243170 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215004

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase + review fix (#2). #

Patch Set 3 : Rebase - the 2nd try - #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -47 lines)			Patch
M	chrome/browser/chromeos/drive/change_list_loader.cc	View		5 chunks	+10 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_integration_service.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/job_scheduler.cc	View	1 2	4 chunks	+9 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/logging.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/logging.cc	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/private_api_base.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/drive/event_logger.h	View	1	3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/drive/event_logger.cc	View		2 chunks	+5 lines, -12 lines	0 comments	Download
M	chrome/browser/drive/event_logger_unittest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/sync_file_system/logger.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

kinaba

ptal. I thought about merging the code that flows the log to base::logging streams (which ...

7 years, 4 months ago (2013-08-01 06:12:43 UTC) #1

hashimoto

lgtm https://codereview.chromium.org/20609006/diff/1/chrome/browser/drive/event_logger.h File chrome/browser/drive/event_logger.h (right): https://codereview.chromium.org/20609006/diff/1/chrome/browser/drive/event_logger.h#newcode41 chrome/browser/drive/event_logger.h:41: // Logs a message using printf format. nit: ...

7 years, 4 months ago (2013-08-01 06:19:59 UTC) #2

kinaba

https://codereview.chromium.org/20609006/diff/1/chrome/browser/drive/event_logger.h File chrome/browser/drive/event_logger.h (right): https://codereview.chromium.org/20609006/diff/1/chrome/browser/drive/event_logger.h#newcode41 chrome/browser/drive/event_logger.h:41: // Logs a message using printf format. On 2013/08/01 ...

7 years, 4 months ago (2013-08-01 06:37:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/20609006/18001

7 years, 4 months ago (2013-08-01 07:03:10 UTC) #6

Message was sent while issue was closed.

Change committed as 215004

Expand Messages | Collapse Messages