PPC: Fix arguments object stubs for large arrays.

PPC: Fix arguments object stubs for large arrays.

Port e95cfafb67dba67eb7c541d97f5e69f8280df771

Original commit message:

    This fixes FastNewStrictArgumentsStub and FastNewRestParameterStub to no
    longer assume that the strict arguments object being allocated will fit
    into new-space. The case where said object needs to move to large object
    space is now handled in the runtime.

R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=chromium:614727
LOG=N

Committed: https://crrev.com/145e16c39fab61b43ded33c6c2f18b596634bf39
Cr-Commit-Position: refs/heads/master@{#36934}

[JaideepBajwa, 2016-06-13 14:50:08]

PTAL

[john.yan, 2016-06-13 14:51:53]

lgtm

[Michael Starzinger, 2016-06-13 14:53:12]

LGTM with one comment.

https://codereview.chromium.org/2060893002/diff/1/src/ppc/code-stubs-ppc.cc
File src/ppc/code-stubs-ppc.cc (right):

https://codereview.chromium.org/2060893002/diff/1/src/ppc/code-stubs-ppc.cc#n...
src/ppc/code-stubs-ppc.cc:4698: __ cmpi(r4,
Operand(Page::kMaxRegularHeapObjectSize));
I had a bug in my ARM code, s/r4/r10/ here I think. I fixed it in a subsequent
CL on ARM by now. Sorry about that.

https://codereview.chromium.org/2060893002/diff/1/src/ppc/code-stubs-ppc.cc#n...
src/ppc/code-stubs-ppc.cc:4702: __ SmiTag(r4);
Likewise: s/r4/r10/

https://codereview.chromium.org/2060893002/diff/1/src/ppc/code-stubs-ppc.cc#n...
src/ppc/code-stubs-ppc.cc:4703: __ Push(r3, r5, r4);
Likewise: s/r4/r10/

[JoranSiu, 2016-06-13 14:53:37]

On 2016/06/13 14:50:08, JaideepBajwa wrote:
> PTAL

lgtm

[Michael Starzinger, 2016-06-13 14:54:52]

https://codereview.chromium.org/2060893002/diff/1/src/ppc/code-stubs-ppc.cc
File src/ppc/code-stubs-ppc.cc (right):

https://codereview.chromium.org/2060893002/diff/1/src/ppc/code-stubs-ppc.cc#n...
src/ppc/code-stubs-ppc.cc:4698: __ cmpi(r4,
Operand(Page::kMaxRegularHeapObjectSize));
On 2016/06/13 14:53:11, Michael Starzinger wrote:
> I had a bug in my ARM code, s/r4/r10/ here I think. I fixed it in a subsequent
> CL on ARM by now. Sorry about that.

Referring to this: https://codereview.chromium.org/2066493002

[JaideepBajwa, 2016-06-13 15:00:22]

On 2016/06/13 14:53:12, Michael Starzinger wrote:
> LGTM with one comment.
> 
> https://codereview.chromium.org/2060893002/diff/1/src/ppc/code-stubs-ppc.cc
> File src/ppc/code-stubs-ppc.cc (right):
> 
>
https://codereview.chromium.org/2060893002/diff/1/src/ppc/code-stubs-ppc.cc#n...
> src/ppc/code-stubs-ppc.cc:4698: __ cmpi(r4,
> Operand(Page::kMaxRegularHeapObjectSize));
> I had a bug in my ARM code, s/r4/r10/ here I think. I fixed it in a subsequent
> CL on ARM by now. Sorry about that.
> 
>
https://codereview.chromium.org/2060893002/diff/1/src/ppc/code-stubs-ppc.cc#n...
> src/ppc/code-stubs-ppc.cc:4702: __ SmiTag(r4);
> Likewise: s/r4/r10/
> 
>
https://codereview.chromium.org/2060893002/diff/1/src/ppc/code-stubs-ppc.cc#n...
> src/ppc/code-stubs-ppc.cc:4703: __ Push(r3, r5, r4);
> Likewise: s/r4/r10/

Thanks, added the fix.

[JaideepBajwa, 2016-06-13 15:00:54]

The CQ bit was checked by bjaideep@ca.ibm.com

[JaideepBajwa, 2016-06-13 15:00:55]

The patchset sent to the CQ was uploaded after l-g-t-m from jyan@ca.ibm.com,
joransiu@ca.ibm.com, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2060893002/#ps20001
(title: "Fix typo in FastNewRestParameterStub::Generate")

[commit-bot: I haz the power, 2016-06-13 15:01:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060893002/20001

[commit-bot: I haz the power, 2016-06-13 15:28:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-13 15:29:04]

Description was changed from

==========
PPC: Fix arguments object stubs for large arrays.

Port e95cfafb67dba67eb7c541d97f5e69f8280df771

Original commit message:

    This fixes FastNewStrictArgumentsStub and FastNewRestParameterStub to no
    longer assume that the strict arguments object being allocated will fit
    into new-space. The case where said object needs to move to large object
    space is now handled in the runtime.

R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=chromium:614727
LOG=N
==========

to

==========
PPC: Fix arguments object stubs for large arrays.

Port e95cfafb67dba67eb7c541d97f5e69f8280df771

Original commit message:

    This fixes FastNewStrictArgumentsStub and FastNewRestParameterStub to no
    longer assume that the strict arguments object being allocated will fit
    into new-space. The case where said object needs to move to large object
    space is now handled in the runtime.

R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=chromium:614727
LOG=N

Committed: https://crrev.com/145e16c39fab61b43ded33c6c2f18b596634bf39
Cr-Commit-Position: refs/heads/master@{#36934}
==========

[commit-bot: I haz the power, 2016-06-13 15:29:05]

Patchset 2 (id:??) landed as
https://crrev.com/145e16c39fab61b43ded33c6c2f18b596634bf39
Cr-Commit-Position: refs/heads/master@{#36934}