Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2060843002: [compiler] Remove bailout in ast-numbering's VisitYield. (Closed)

Created:
4 years, 6 months ago by neis
Modified:
4 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove bailout in ast-numbering's VisitYield. It's sufficient to bailout when seeing that the function literal is a generator or async function, as those are the only cases in which there can be yields. Also: add a comment on --turbo-from-bytecode and Ignition generators. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/552ba59eb2eb05804bd4b8304ef29a45706d0b7f Cr-Commit-Position: refs/heads/master@{#36930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/ast/ast-numbering.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/bailout-reason.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
neis
4 years, 6 months ago (2016-06-13 12:17:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060843002/1
4 years, 6 months ago (2016-06-13 12:22:20 UTC) #3
Michael Starzinger
LGTM.
4 years, 6 months ago (2016-06-13 12:23:26 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-13 12:51:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060843002/1
4 years, 6 months ago (2016-06-13 12:52:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 12:54:40 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 12:54:42 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 12:56:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/552ba59eb2eb05804bd4b8304ef29a45706d0b7f
Cr-Commit-Position: refs/heads/master@{#36930}

Powered by Google App Engine
This is Rietveld 408576698