media/audio/audio_output_controller.h - Issue 2060833002: Implementation of 'AudioContext.getOutputTimestamp' method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/audio_output_controller.h

Issue 2060833002: Implementation of 'AudioContext.getOutputTimestamp' method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added implementation for ALSA. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/audio/audio_io.h ('K') | « media/audio/audio_low_latency_input_output_unittest.cc ('k') | media/audio/audio_output_controller.cc » ('j') | third_party/WebKit/Source/modules/webaudio/AudioTimestamp.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/audio/audio_output_controller.h

diff --git a/media/audio/audio_output_controller.h b/media/audio/audio_output_controller.h

index e954eabfc7cfa75a71232716641c4b3b093859c4..04ca7af455446b834b103b5b961fca5cae15cd96 100644

--- a/media/audio/audio_output_controller.h

+++ b/media/audio/audio_output_controller.h

@@ -93,7 +93,8 @@ class MEDIA_EXPORT AudioOutputController

// source can handle this appropriately depending on the type of source. An

// ordinary file playout would ignore this.

virtual void UpdatePendingBytes(uint32_t bytes,

- uint32_t frames_skipped) = 0;

+ uint32_t frames_skipped,

+ const AudioTimestamp& output_timestamp) = 0;

// Attempts to completely fill |dest|, zeroing |dest| if the request can not

// be fulfilled (due to timeout).

@@ -165,7 +166,8 @@ class MEDIA_EXPORT AudioOutputController

// AudioSourceCallback implementation.

int OnMoreData(AudioBus* dest,

uint32_t total_bytes_delay,

- uint32_t frames_skipped) override;

+ uint32_t frames_skipped,

+ const AudioTimestamp& output_timestamp) override;

void OnError(AudioOutputStream* stream) override;

// AudioDeviceListener implementation. When called AudioOutputController will