media/audio/alsa/alsa_output_unittest.cc - Issue 2060833002: Implementation of 'AudioContext.getOutputTimestamp' method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/alsa/alsa_output_unittest.cc

Issue 2060833002: Implementation of 'AudioContext.getOutputTimestamp' method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added implementation for ALSA. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/audio/alsa/alsa_output_unittest.cc

diff --git a/media/audio/alsa/alsa_output_unittest.cc b/media/audio/alsa/alsa_output_unittest.cc

index ce66804bf80c2c3d787d505545133d69bb737d63..6c9a161945d55de4f80afd228bf19787f4d64bef 100644

--- a/media/audio/alsa/alsa_output_unittest.cc

+++ b/media/audio/alsa/alsa_output_unittest.cc

@@ -432,7 +432,7 @@ TEST_F(AlsaPcmOutputStreamTest, StartStop) {

.WillRepeatedly(Return(SND_PCM_STATE_RUNNING));

EXPECT_CALL(mock_alsa_wrapper_, PcmDelay(kFakeHandle, _))

.WillRepeatedly(DoAll(SetArgumentPointee<1>(0), Return(0)));

- EXPECT_CALL(mock_callback, OnMoreData(_, _, 0))

+ EXPECT_CALL(mock_callback, OnMoreData(_, _, 0, AudioTimestamp()))

.WillRepeatedly(DoAll(ClearBuffer(), Return(kTestFramesPerPacket)));

EXPECT_CALL(mock_alsa_wrapper_, PcmWritei(kFakeHandle, _, _))

.WillRepeatedly(Return(kTestFramesPerPacket));

@@ -595,7 +595,7 @@ TEST_F(AlsaPcmOutputStreamTest, BufferPacket) {

.WillRepeatedly(Return(0)); // Buffer is full.

// Return a partially filled packet.

- EXPECT_CALL(mock_callback, OnMoreData(_, _, 0))

+ EXPECT_CALL(mock_callback, OnMoreData(_, _, 0, AudioTimestamp()))

.WillOnce(DoAll(ClearBuffer(), Return(kTestFramesPerPacket / 2)));

bool source_exhausted;

@@ -621,7 +621,7 @@ TEST_F(AlsaPcmOutputStreamTest, BufferPacket_Negative) {

.WillOnce(DoAll(SetArgumentPointee<1>(-1), Return(0)));

EXPECT_CALL(mock_alsa_wrapper_, PcmAvailUpdate(_))

.WillRepeatedly(Return(0)); // Buffer is full.

- EXPECT_CALL(mock_callback, OnMoreData(_, _, 0))

+ EXPECT_CALL(mock_callback, OnMoreData(_, _, 0, AudioTimestamp()))

.WillOnce(DoAll(ClearBuffer(), Return(kTestFramesPerPacket / 2)));

bool source_exhausted;

@@ -645,7 +645,7 @@ TEST_F(AlsaPcmOutputStreamTest, BufferPacket_Underrun) {

.WillOnce(Return(SND_PCM_STATE_XRUN));

EXPECT_CALL(mock_alsa_wrapper_, PcmAvailUpdate(_))

.WillRepeatedly(Return(0)); // Buffer is full.

- EXPECT_CALL(mock_callback, OnMoreData(_, 0, 0))

+ EXPECT_CALL(mock_callback, OnMoreData(_, 0, 0, AudioTimestamp()))

.WillOnce(DoAll(ClearBuffer(), Return(kTestFramesPerPacket / 2)));

bool source_exhausted;

« no previous file with comments | « media/audio/alsa/alsa_output.cc ('k') | media/audio/audio_device_thread.h » ('j') | media/audio/audio_io.h » ('J')