media/audio/audio_device_thread.h - Issue 2060833002: Implementation of 'AudioContext.getOutputTimestamp' method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/audio_device_thread.h

Issue 2060833002: Implementation of 'AudioContext.getOutputTimestamp' method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Implementation of 'AudioContext.getOutputTimestamp' method Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/renderer_webaudiodevice_impl.cc ('K') | « media/audio/alsa/alsa_output_unittest.cc ('k') | media/audio/audio_device_thread.cc » ('j') | media/audio/audio_output_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/audio/audio_device_thread.h

diff --git a/media/audio/audio_device_thread.h b/media/audio/audio_device_thread.h

index 61e5e8724ddc24b289c01c364e3491b137779462..9f36fb4e8fa8833ed04f09e3cd841942c8d16c98 100644

--- a/media/audio/audio_device_thread.h

+++ b/media/audio/audio_device_thread.h

@@ -12,6 +12,7 @@

#include "base/memory/shared_memory.h"

#include "base/sync_socket.h"

#include "base/synchronization/lock.h"

+#include "media/audio/audio_io.h"

#include "media/base/audio_parameters.h"

#include "media/base/media_export.h"

@@ -21,6 +22,7 @@ class MessageLoop;

namespace media {

class AudioBus;

+struct AudioTimestamp;

// Data transfer between browser and render process uses a combination

// of sync sockets and shared memory. To read from the socket and render

@@ -52,7 +54,8 @@ class MEDIA_EXPORT AudioDeviceThread {

virtual void MapSharedMemory() = 0;

// Called whenever we receive notifications about pending input data.

hongchan 2016/06/14 17:10:38 Let's expand the comment to reflect the change of

Mikhail 2016/06/17 09:36:57 Done.

- virtual void Process(uint32_t pending_data) = 0;

+ virtual void Process(uint32_t pending_data,

+ const AudioTimestamp& timestamp) = 0;

protected:

// Protected so that derived classes can access directly.