Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: webkit/browser/fileapi/local_file_stream_writer.cc

Issue 206083004: Revert of Revert of Add a parameter to FileStreamWriter::CreateForLocalFile to allow creating new (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/browser/fileapi/local_file_stream_writer.cc
diff --git a/webkit/browser/fileapi/local_file_stream_writer.cc b/webkit/browser/fileapi/local_file_stream_writer.cc
index 1796de5f4e894afd0dd8ad97cd63b339980b44d0..45e358af948fa2ba1a6294c97db79c8dda3ed539 100644
--- a/webkit/browser/fileapi/local_file_stream_writer.cc
+++ b/webkit/browser/fileapi/local_file_stream_writer.cc
@@ -17,14 +17,19 @@
const int kOpenFlagsForWrite = base::PLATFORM_FILE_OPEN |
base::PLATFORM_FILE_WRITE |
base::PLATFORM_FILE_ASYNC;
+const int kCreateFlagsForWrite = base::PLATFORM_FILE_CREATE |
+ base::PLATFORM_FILE_WRITE |
+ base::PLATFORM_FILE_ASYNC;
} // namespace
FileStreamWriter* FileStreamWriter::CreateForLocalFile(
base::TaskRunner* task_runner,
const base::FilePath& file_path,
- int64 initial_offset) {
- return new LocalFileStreamWriter(task_runner, file_path, initial_offset);
+ int64 initial_offset,
+ OpenOrCreate open_or_create) {
+ return new LocalFileStreamWriter(
+ task_runner, file_path, initial_offset, open_or_create);
}
LocalFileStreamWriter::~LocalFileStreamWriter() {
@@ -81,8 +86,10 @@
LocalFileStreamWriter::LocalFileStreamWriter(base::TaskRunner* task_runner,
const base::FilePath& file_path,
- int64 initial_offset)
+ int64 initial_offset,
+ OpenOrCreate open_or_create)
: file_path_(file_path),
+ open_or_create_(open_or_create),
initial_offset_(initial_offset),
task_runner_(task_runner),
has_pending_operation_(false),
@@ -96,8 +103,18 @@
stream_impl_.reset(new net::FileStream(NULL, task_runner_));
+ int open_flags = 0;
+ switch (open_or_create_) {
+ case OPEN_EXISTING_FILE:
+ open_flags = kOpenFlagsForWrite;
+ break;
+ case CREATE_NEW_FILE:
+ open_flags = kCreateFlagsForWrite;
+ break;
+ }
+
return stream_impl_->Open(file_path_,
- kOpenFlagsForWrite,
+ open_flags,
base::Bind(&LocalFileStreamWriter::DidOpen,
weak_factory_.GetWeakPtr(),
error_callback,
« no previous file with comments | « webkit/browser/fileapi/local_file_stream_writer.h ('k') | webkit/browser/fileapi/local_file_stream_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698