Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: src/core/SkOpts.h

Issue 2060823003: Implement fast, correct gamma conversion for color xforms (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Should be 0xFF Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/core/SkOpts.h
diff --git a/src/core/SkOpts.h b/src/core/SkOpts.h
index 0711471fb4d3c2ccdb4cc886237ab84a81403a09..2deb580b703b46db4140f8a7fc3068971317a766 100644
--- a/src/core/SkOpts.h
+++ b/src/core/SkOpts.h
@@ -69,10 +69,11 @@ namespace SkOpts {
// If nsrc < ndst, we loop over src to create a pattern.
extern void (*srcover_srgb_srgb)(uint32_t* dst, const uint32_t* src, int ndst, int nsrc);
- // Color xform RGBA input into SkPMColor ordered 8888 pixels. Does not premultiply, and
- // assumes src and dst gamma curves are both 2.2f exponentials.
- extern void (*color_xform_2Dot2_RGBA_to_8888)(uint32_t* dst, const uint32_t* src, int len,
- const float srcToDstMatrix[16]);
+ // Color xform RGB1 input into SkPMColor ordered 8888 opaque pixels.
mtklein_C 2016/06/16 13:27:40 Doesn't this actually transform RGBA into RGB1 pix
mtklein 2016/06/16 13:29:28 Err, RGB1 -> RGB1. Just interested in color order
msarett 2016/06/16 15:46:11 Yes fixing this comment.
+ extern void (*color_xform_RGB1_srgb_to_2dot2) (uint32_t* dst, const uint32_t* src, int len,
+ const float srcToDstMatrix[16]);
+ extern void (*color_xform_RGB1_2dot2_to_2dot2)(uint32_t* dst, const uint32_t* src, int len,
+ const float srcToDstMatrix[16]);
}
#endif//SkOpts_DEFINED

Powered by Google App Engine
This is Rietveld 408576698