Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2060803002: Use separate time values for 32 and 64 bit systems in feature tests (Closed)

Created:
4 years, 6 months ago by maksims (do not use this acc)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use separate time values for 32 and 64 bit systems in feature tests Some test cases fail due to updates to the time conversion functions - https://codereview.chromium.org/1988663002/ The problem is that linux_chromium_dbg_32 starts to fail, when the above mentioned CL is applied, because the date after 2038 cannot be properly converted on 32-bit systems due to 2^32 value limitation. Committed: https://crrev.com/82bb85e827bc47c2918bd77fb8ec81bac68d4146 Cr-Commit-Position: refs/heads/master@{#399715}

Patch Set 1 #

Patch Set 2 : TODO added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/common/extensions/feature_switch_unittest.cc View 1 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
maksims (do not use this acc)
please review
4 years, 6 months ago (2016-06-13 10:03:58 UTC) #4
maksims (do not use this acc)
ping
4 years, 6 months ago (2016-06-14 05:38:33 UTC) #5
Finnur
Sorry, an on offsite so slow to respond. LGTM
4 years, 6 months ago (2016-06-14 13:14:58 UTC) #6
Finnur
> Sorry, an on offsite so slow to respond. Am* on
4 years, 6 months ago (2016-06-14 13:15:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060803002/20001
4 years, 6 months ago (2016-06-14 15:03:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-14 15:41:24 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 15:52:20 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82bb85e827bc47c2918bd77fb8ec81bac68d4146
Cr-Commit-Position: refs/heads/master@{#399715}

Powered by Google App Engine
This is Rietveld 408576698