Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2060753004: gl: Build drm dependent test only when target_os == "chromeos". (Closed)

Created:
4 years, 6 months ago by Daniele Castagna
Modified:
4 years, 6 months ago
Reviewers:
stevenjb, ccameron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gl: Build drm dependent test only when target_os == "chromeos". The original check we used was |is_chromeos| that is true also when the ChromeOS UI is built on linux. More info about the issue here: https://bugs.chromium.org/p/chromium/issues/detail?id=618516#c5 BUG=618516 Committed: https://crrev.com/a6a013030f55b0a53f07fbae950f5f4d1ab3b774 Cr-Commit-Position: refs/heads/master@{#399648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/gl/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Daniele Castagna
4 years, 6 months ago (2016-06-14 01:03:32 UTC) #2
Daniele Castagna
+Chris for ownership approval.
4 years, 6 months ago (2016-06-14 01:06:06 UTC) #5
stevenjb
Thanks for the quick fix. LGTM
4 years, 6 months ago (2016-06-14 01:07:05 UTC) #6
ccameron
OWNER lgtm rs
4 years, 6 months ago (2016-06-14 01:20:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060753004/1
4 years, 6 months ago (2016-06-14 01:53:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 02:59:08 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 02:59:12 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 03:40:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6a013030f55b0a53f07fbae950f5f4d1ab3b774
Cr-Commit-Position: refs/heads/master@{#399648}

Powered by Google App Engine
This is Rietveld 408576698