third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h - Issue 2060753002: Implement script-side of callback reactions for Custom Elements V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

Issue 2060753002: Implement script-side of callback reactions for Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@callback-ce

Patch Set: dominicc review Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/V8Binding.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

index 1589b871786399a756e0a5107305e87a95a92ca0..4293471a6447b77445ebfe541734ed3f8168fb02 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

@@ -50,14 +50,14 @@ private:

v8::Local<v8::Value> m_constructorValue;

v8::Local<v8::Object> m_constructor;

v8::Local<v8::Object> m_prototype;

- v8::Local<v8::Object> m_connectedCallback;

- v8::Local<v8::Object> m_disconnectedCallback;

- v8::Local<v8::Object> m_attributeChangedCallback;

+ v8::Local<v8::Function> m_connectedCallback;

+ v8::Local<v8::Function> m_disconnectedCallback;

+ v8::Local<v8::Function> m_attributeChangedCallback;

HashSet<AtomicString> m_observedAttributes;

ExceptionState& m_exceptionState;

bool valueForName(const v8::Local<v8::Object>&, const String&, v8::Local<v8::Value>&) const;

- bool callableForName(const String&, v8::Local<v8::Object>&) const;

+ bool callableForName(const String&, v8::Local<v8::Function>&) const;

bool retrieveObservedAttributes();

};