third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp - Issue 2060753002: Implement script-side of callback reactions for Custom Elements V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp

Issue 2060753002: Implement script-side of callback reactions for Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@callback-ce

Patch Set: enqueueAttributeChangedCallbackForAllAttributes and test fixes Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp

index a669cec94f5160648341465ff45231c8442c367a..db1c49df5b8ecefcd296a2b78e9df3e63a01d124 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp

@@ -257,6 +257,9 @@ public:

LogUpgradeDefinition(const CustomElementDescriptor& descriptor)

: TestCustomElementDefinition(descriptor)

{

+ m_observedAttributes.add("attr1");

+ m_observedAttributes.add("attr2");

+ m_observedAttributes.add(HTMLNames::contenteditableAttr.localName());

}

DEFINE_INLINE_VIRTUAL_TRACE()

@@ -298,7 +301,6 @@ public:

bool hasConnectedCallback() const override { return true; }

bool hasDisconnectedCallback() const override { return true; }

- bool hasAttributeChangedCallback(const QualifiedName&) const override { return true; }

void runConnectedCallback(Element* element) override

{