Implement script-side of callback reactions for Custom Elements V1

third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
index c6fd2b0ff9112b613ce3185d5dae975af7b97647..c48137460153996c46eb0b8ff86bd6beca308040 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
@@ -9,7 +9,10 @@
 #include "core/CoreExport.h"
 #include "core/dom/custom/CustomElementDescriptor.h"
 #include "platform/heap/Handle.h"
+#include "wtf/HashSet.h"
 #include "wtf/Noncopyable.h"
+#include "wtf/text/AtomicString.h"
+#include "wtf/text/AtomicStringHash.h"
 
 namespace blink {
 
@@ -43,15 +46,14 @@ public:
 
     void upgrade(Element*);
 
-    // TODO(kojii): Change these methods to pure when script-side is implemented.
-    virtual bool hasConnectedCallback() const { return true; }
-    virtual bool hasDisconnectedCallback() const { return true; }
-    virtual bool hasAttributeChangedCallback(const QualifiedName&) const { return true; }
+    virtual bool hasConnectedCallback() const = 0;
+    virtual bool hasDisconnectedCallback() const = 0;
+    bool hasAttributeChangedCallback(const QualifiedName&);
 
-    virtual void runConnectedCallback(Element*) {}
-    virtual void runDisconnectedCallback(Element*) {}
+    virtual void runConnectedCallback(Element*) = 0;
+    virtual void runDisconnectedCallback(Element*) = 0;
     virtual void runAttributeChangedCallback(Element*, const QualifiedName&,
-        const AtomicString& oldValue, const AtomicString& newValue) {}
+        const AtomicString& oldValue, const AtomicString& newValue) = 0;
 
     void enqueueUpgradeReaction(Element*);
     void enqueueConnectedCallback(Element*);
@@ -62,9 +64,13 @@ public:
 protected:
     virtual bool runConstructor(Element*) = 0;
 
+    HashSet<AtomicString> m_observedAttributes;
+
 private:
     const CustomElementDescriptor m_descriptor;
     ConstructionStack m_constructionStack;
+
+    void enqueueAttributeChangedCallbackForAllAttributes(Element*);
 };
 
 } // namespace blink