ArraySplice builtin handlified.

src/factory.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 337 matching lines @@
 
   Handle<JSObject> NewJSObjectFromMapForDeoptimizer(
       Handle<Map> map, PretenureFlag pretenure = NOT_TENURED);
 
   // JS modules are pretenured.
   Handle<JSModule> NewJSModule(Handle<Context> context,
                                Handle<ScopeInfo> scope_info);
 
   // JS arrays are pretenured when allocated by the parser.
   Handle<JSArray> NewJSArray(
+      ElementsKind elements_kind,
+      int length,
+      int capacity,
+      PretenureFlag pretenure = NOT_TENURED);
+
+  Handle<JSArray> NewJSArray(
       int capacity,
       ElementsKind elements_kind = TERMINAL_FAST_ELEMENTS_KIND,
+      PretenureFlag pretenure = NOT_TENURED) {
+    return NewJSArray(elements_kind, 0, capacity, pretenure);

[Yang, 2014/03/20 15:21:41]

Do we really need this wrapper?

[Igor Sheludko, 2014/03/21 09:49:39]

The NewJSArray() without length was here for some time and already has a number
of usages. But in my case I needed a more general one having both length and
capacity parameters. So I added it (see above) and defined the old one as a
special case of a new one.

+  }
+
+  Handle<JSArray> NewJSArrayWithElements(
+      Handle<FixedArrayBase> elements,
+      ElementsKind elements_kind,
+      int length,
       PretenureFlag pretenure = NOT_TENURED);

[Yang, 2014/03/20 15:21:41]

Same here.

[Igor Sheludko, 2014/03/21 09:49:39]

Same here for NewJSArrayWithElements(). To make this relationship more explicit
I'll move the implementation of the specific case to the header.

 
   Handle<JSArray> NewJSArrayWithElements(
       Handle<FixedArrayBase> elements,
       ElementsKind elements_kind = TERMINAL_FAST_ELEMENTS_KIND,
       PretenureFlag pretenure = NOT_TENURED);
 
   void NewJSArrayStorage(
       Handle<JSArray> array,
       int length,
       int capacity,
@@ skipping 246 matching lines @@
                           isolate());
   } else {
     return NewNumber(static_cast<double>(value), pretenure);
   }
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_FACTORY_H_