Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Unified Diff: Source/core/inspector/CodeGeneratorInstrumentation.py

Issue 206073005: PassRefPtr is stolen by first agent invocation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: chmod Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/CodeGeneratorInstrumentation.py
diff --git a/Source/core/inspector/CodeGeneratorInstrumentation.py b/Source/core/inspector/CodeGeneratorInstrumentation.py
old mode 100644
new mode 100755
index aa84d844a1a7f8cd59ac36c8fc82c74b37dbc700..c31371766163373f9e931040a4b25fb3a24b68cd
--- a/Source/core/inspector/CodeGeneratorInstrumentation.py
+++ b/Source/core/inspector/CodeGeneratorInstrumentation.py
@@ -353,7 +353,7 @@ class Method:
agent_class=agent_class,
agent_fetch=agent_fetch,
maybe_return=maybe_return,
- params_agent=", ".join(map(Parameter.to_str_name, self.params_impl)[1:]))
+ params_agent=", ".join(map(Parameter.to_str_value, self.params_impl)[1:]))
class Parameter:
@@ -384,6 +384,12 @@ class Parameter:
self.type = param_decl
self.name = generate_param_name(self.type)
+ if re.match("PassRefPtr<", param_decl):
+ self.value = "%s.get()" % self.name
+ else:
+ self.value = self.name
+
+
def to_str_full(self):
if self.default_value is None:
return self.to_str_class_and_name()
@@ -398,6 +404,9 @@ class Parameter:
def to_str_name(self):
return self.name
+ def to_str_value(self):
+ return self.value
+
def generate_param_name(param_type):
base_name = re.match("(const |PassRefPtr<)?(\w*)", param_type).group(2)
« no previous file with comments | « no previous file | Source/core/inspector/InspectorConsoleAgent.h » ('j') | Source/core/inspector/InspectorConsoleAgent.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698