Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Issue 2060713002: Respect the order of input messages from browser to renderer (Closed)

Created:
4 years, 6 months ago by Changwan Ryu
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Respect the order of input messages from browser to renderer When we call InputConnection#setSelection and other methods together, the order sometimes does not get kept. The reason is that SetEditableSelectionOffsets is a frame message while all the others are input messages, and they go to different message queues. In addition, RenderViewImpl is the only who registers its routing ID through InputHandlerManager::AddInputHandler() call. RenderFrameImpl, on the other hand, does not register itself. Once routing ID is registered, InputEventFilter will post input messages to compositor impl thread first (such that scrolling can happen inside compositor impl thread and keep in line with other input message handling order). We fix this by 1) Changing SetEditableSelectionOffsets from FrameMsg to InputMsg. (Now there is no remaining frame messages in ime_adapter_android.cc.) 2) Change DidAddInputHandler() and DidRemoveInputHandler() names to RegisterRoutingID() and UnregisterRoutingID(), respectively. 3) Register RenderFrame's routing ID at InputEventFilter. BUG=601707 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/1877073003 Cr-Commit-Position: refs/heads/master@{#399404} (cherry picked from commit d659e20ed5d564cca67934147b481a32a59f3f6a) Committed: https://chromium.googlesource.com/chromium/src/+/17ab5a827acb2ae1dbf1a53181d0dd09a0769766

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -38 lines) Patch
M content/browser/frame_host/interstitial_page_impl_browsertest.cc View 4 chunks +13 lines, -0 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/common/input_messages.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 chunk +24 lines, -0 lines 0 comments Download
M content/public/renderer/render_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/input/input_event_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/input/input_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/input/input_event_filter_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/input/input_handler_manager.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/input/input_handler_manager.cc View 3 chunks +35 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_manager_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 5 chunks +19 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Changwan Ryu
4 years, 6 months ago (2016-06-13 03:33:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
17ab5a827acb2ae1dbf1a53181d0dd09a0769766.

Powered by Google App Engine
This is Rietveld 408576698