Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2060673002: [turbofan] Retiring Greedy Allocator (Closed)

Created:
4 years, 6 months ago by Mircea Trofin
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich, bbudge
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Retiring Greedy Allocator We were able to achieve our goals for register allocation independent of the allocation algorithm. Performance data so far is inconclusive re. the value of the Greedy algorithm, compared to the particular Linear Scan implementation we're currently using, and the performance measurement techniques we currently use are too imprecise to help with this matter. Retiring the algorithm to lower maintenance and evolution cost (e.g. lower cost of adding aliasing support). Once we improve benchmarking stability, and establish a suite sensitive enough for codegen improvement studies, we may revive the algorithm, should the need arise. BUG= Committed: https://crrev.com/8e1ccba3b0a91fa2ce4e3037cd1ff97013433c4a Cr-Commit-Position: refs/heads/master@{#36912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1468 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
D src/compiler/coalesced-live-ranges.h View 1 chunk +0 lines, -158 lines 0 comments Download
D src/compiler/coalesced-live-ranges.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D src/compiler/greedy-allocator.h View 1 chunk +0 lines, -199 lines 0 comments Download
D src/compiler/greedy-allocator.cc View 1 chunk +0 lines, -629 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/compiler/register-allocator.h View 3 chunks +0 lines, -22 lines 0 comments Download
M src/compiler/register-allocator.cc View 4 chunks +1 line, -27 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M test/unittests/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
D test/unittests/compiler/coalesced-live-ranges-unittest.cc View 1 chunk +0 lines, -268 lines 0 comments Download
M test/unittests/compiler/register-allocator-unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Mircea Trofin
4 years, 6 months ago (2016-06-12 13:40:22 UTC) #3
Benedikt Meurer
LGTM.
4 years, 6 months ago (2016-06-13 04:20:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060673002/1
4 years, 6 months ago (2016-06-13 04:21:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 04:23:45 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8e1ccba3b0a91fa2ce4e3037cd1ff97013433c4a Cr-Commit-Position: refs/heads/master@{#36912}
4 years, 6 months ago (2016-06-13 04:24:23 UTC) #10
Michael Achenbach
4 years, 6 months ago (2016-06-13 06:29:34 UTC) #11
Message was sent while issue was closed.
Does that mean the bots can be removed?

Powered by Google App Engine
This is Rietveld 408576698