Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 206063006: Require HTTPS for admin.google.com. (Closed)

Created:
6 years, 9 months ago by Joao da Silva
Modified:
6 years, 9 months ago
Reviewers:
palmer, agl, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M net/http/transport_security_state_static.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/http/transport_security_state_static.json View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Joao da Silva
Hi Chris, does this change make sense to you? :-) I'm not sure this is ...
6 years, 9 months ago (2014-03-20 13:46:25 UTC) #1
palmer
LGTM. Thanks!
6 years, 9 months ago (2014-03-20 16:18:14 UTC) #2
Joao da Silva
@agl, @rsleevi: friendly ping! Does this change make sense to you? Should we check something ...
6 years, 9 months ago (2014-03-21 09:24:58 UTC) #3
agl
LGTM.
6 years, 9 months ago (2014-03-21 14:59:58 UTC) #4
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 9 months ago (2014-03-21 15:02:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/206063006/1
6 years, 9 months ago (2014-03-21 15:03:26 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 15:32:33 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=56731
6 years, 9 months ago (2014-03-21 15:32:34 UTC) #8
Joao da Silva
6 years, 9 months ago (2014-03-24 11:11:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r258907 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698