Issue 206063003: DevTools: Extract SourcesEditor from SourcesPanel.

Issue 206063003: DevTools: Extract SourcesEditor from SourcesPanel. (Closed)

Created:
6 years, 9 months ago by vsevik

Modified:
6 years, 9 months ago

Reviewers:
lushnikov, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Extract SourcesEditor from SourcesPanel. This extracts everything related to our tabbed editor from the sources panel to the separate SourcesEditor class. This class could be later refactored into the view that could be embedded in other places (e.g. Drawer). R=pfeldman, lushnikov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169653

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+827 lines, -735 lines)			Patch
M	LayoutTests/http/tests/inspector/debugger-test.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/inspector/jump-to-previous-editing-location.html	View		2 chunks	+7 lines, -4 lines	0 comments	Download
M	LayoutTests/inspector/sources/debugger/source-frame-count.html	View		2 chunks	+1 line, -2 lines	1 comment	Download
M	Source/devtools/devtools.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/EditingLocationHistoryManager.js	View		5 chunks	+9 lines, -9 lines	0 comments	Download
M	Source/devtools/front_end/ExtensionServer.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/FilteredItemSelectionDialog.js	View		5 chunks	+10 lines, -12 lines	0 comments	Download
M	Source/devtools/front_end/InplaceFormatterEditorAction.js	View		4 chunks	+9 lines, -9 lines	0 comments	Download
M	Source/devtools/front_end/ScriptFormatterEditorAction.js	View		4 chunks	+10 lines, -10 lines	0 comments	Download
A	Source/devtools/front_end/SourcesEditor.js	View		1 chunk	+708 lines, -0 lines	1 comment	Download
M	Source/devtools/front_end/SourcesPanel.js	View	1	23 chunks	+66 lines, -684 lines	0 comments	Download
M	Source/devtools/front_end/modules.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/scripts/frontend_modules.json	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

lushnikov

lgtm given the tests pass https://codereview.chromium.org/206063003/diff/10001/LayoutTests/inspector/sources/debugger/source-frame-count.html File LayoutTests/inspector/sources/debugger/source-frame-count.html (right): https://codereview.chromium.org/206063003/diff/10001/LayoutTests/inspector/sources/debugger/source-frame-count.html#newcode51 LayoutTests/inspector/sources/debugger/source-frame-count.html:51: InspectorTest.assertTrue(panel.visibleView._uiSourceCode.originURL().indexOf("script3.js") !== -1); shouldn't ...

6 years, 9 months ago (2014-03-20 13:13:42 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/206063003/10001

6 years, 9 months ago (2014-03-20 13:15:03 UTC) #4

Message was sent while issue was closed.

Change committed as 169653

Expand Messages | Collapse Messages