Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2060613002: Generate VS projects also for target dependencies. (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate VS projects also for target dependencies. This changes the way the --filters argument to `gn gen --ide=vs --filters=X;Y;...` works so that the information for all the dependents of X and Y will be generated along with the information for X and Y. This CL is based on tmoniuszko@opera.com's patch from issue 2027733004 at patchset 1 (http://crrev.com/2027733004#ps1), just updated w/ the review feedback, so we can land it. R=brettw@chromium.org, pkasting@chromium.org, tmoniuszko@opera.com BUG=589099 Committed: https://crrev.com/4ed6b5594a150bd4de269ab71dfc36d812aa6161 Cr-Commit-Position: refs/heads/master@{#399402}

Patch Set 1 : original patchset #

Patch Set 2 : update w/ review feedback #

Patch Set 3 : update docs for --filters, older GN changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -28 lines) Patch
M tools/gn/command_gen.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/docs/reference.md View 1 2 5 chunks +24 lines, -14 lines 0 comments Download
M tools/gn/visual_studio_writer.cc View 1 4 chunks +44 lines, -12 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
Dirk Pranke
Please take a look? Tomasz' original patch had LGTM's, but I figure it doesn't hurt ...
4 years, 6 months ago (2016-06-10 23:21:56 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060613002/20001
4 years, 6 months ago (2016-06-10 23:22:54 UTC) #3
Peter Kasting
Brett's comment from the other CL: "I think the help for --filter in command_gen.cc should ...
4 years, 6 months ago (2016-06-10 23:35:17 UTC) #4
Dirk Pranke
On 2016/06/10 23:35:17, Peter Kasting wrote: > Brett's comment from the other CL: "I think ...
4 years, 6 months ago (2016-06-11 00:07:59 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/245151)
4 years, 6 months ago (2016-06-11 00:59:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060613002/40001
4 years, 6 months ago (2016-06-12 00:32:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/245316)
4 years, 6 months ago (2016-06-12 01:40:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060613002/40001
4 years, 6 months ago (2016-06-12 02:30:20 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/245320)
4 years, 6 months ago (2016-06-12 03:36:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060613002/40001
4 years, 6 months ago (2016-06-12 04:20:41 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/245328)
4 years, 6 months ago (2016-06-12 05:27:27 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060613002/40001
4 years, 6 months ago (2016-06-13 01:10:11 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-13 01:42:27 UTC) #23
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 01:44:20 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4ed6b5594a150bd4de269ab71dfc36d812aa6161
Cr-Commit-Position: refs/heads/master@{#399402}

Powered by Google App Engine
This is Rietveld 408576698