Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/clang/blink_gc_plugin/Edge.cpp

Issue 2060553002: GC plugin: improve error reporting when tracing illegal fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: robustify namespace equality checking instead Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/Edge.h ('k') | tools/clang/blink_gc_plugin/RecordInfo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/Edge.cpp
diff --git a/tools/clang/blink_gc_plugin/Edge.cpp b/tools/clang/blink_gc_plugin/Edge.cpp
index c56a576414896e0bf9998fe1358341484c278d31..77c6cfec4ba9013dd0988075a4093d851471d571 100644
--- a/tools/clang/blink_gc_plugin/Edge.cpp
+++ b/tools/clang/blink_gc_plugin/Edge.cpp
@@ -17,9 +17,11 @@ void RecursiveEdgeVisitor::AtValue(Value*) {}
void RecursiveEdgeVisitor::AtRawPtr(RawPtr*) {}
void RecursiveEdgeVisitor::AtRefPtr(RefPtr*) {}
void RecursiveEdgeVisitor::AtOwnPtr(OwnPtr*) {}
+void RecursiveEdgeVisitor::AtUniquePtr(UniquePtr*) {}
void RecursiveEdgeVisitor::AtMember(Member*) {}
void RecursiveEdgeVisitor::AtWeakMember(WeakMember*) {}
void RecursiveEdgeVisitor::AtPersistent(Persistent*) {}
+void RecursiveEdgeVisitor::AtCrossThreadPersistent(CrossThreadPersistent*) {}
void RecursiveEdgeVisitor::AtCollection(Collection*) {}
void RecursiveEdgeVisitor::VisitValue(Value* e) {
@@ -46,6 +48,13 @@ void RecursiveEdgeVisitor::VisitOwnPtr(OwnPtr* e) {
Leave();
}
+void RecursiveEdgeVisitor::VisitUniquePtr(UniquePtr* e) {
+ AtUniquePtr(e);
+ Enter(e);
+ e->ptr()->Accept(this);
+ Leave();
+}
+
void RecursiveEdgeVisitor::VisitMember(Member* e) {
AtMember(e);
Enter(e);
@@ -67,6 +76,14 @@ void RecursiveEdgeVisitor::VisitPersistent(Persistent* e) {
Leave();
}
+void RecursiveEdgeVisitor::VisitCrossThreadPersistent(
+ CrossThreadPersistent* e) {
+ AtCrossThreadPersistent(e);
+ Enter(e);
+ e->ptr()->Accept(this);
+ Leave();
+}
+
void RecursiveEdgeVisitor::VisitCollection(Collection* e) {
AtCollection(e);
Enter(e);
« no previous file with comments | « tools/clang/blink_gc_plugin/Edge.h ('k') | tools/clang/blink_gc_plugin/RecordInfo.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698