tools/clang/blink_gc_plugin/tests/persistent_no_trace.txt - Issue 2060553002: GC plugin: improve error reporting when tracing illegal fields.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/persistent_no_trace.txt

Issue 2060553002: GC plugin: improve error reporting when tracing illegal fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: robustify namespace equality checking instead Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/persistent_no_trace.cpp ('k') | tools/clang/blink_gc_plugin/tests/templated_class_with_local_class_requires_trace.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 persistent_no_trace.cpp:9:1: warning: [blink-gc] Class 'HeapObject' has untraced or not traceable fields.

	2 void HeapObject::trace(Visitor* visitor) {

	3 ^

	4 ./persistent_no_trace.h:16:5: note: [blink-gc] Untraceable field 'm_crossThreadP ersistent' declared here:

	5 CrossThreadPersistent<HeapObject> m_crossThreadPersistent;

	6 ^

	7 ./persistent_no_trace.h:17:5: note: [blink-gc] Untraceable field 'm_crossThreadW eakPersistent' declared here:

	8 CrossThreadWeakPersistent<HeapObject> m_crossThreadWeakPersistent;

	9 ^

	10 1 warning generated.

OLD	NEW