GC plugin: improve error reporting when tracing illegal fields.

tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "BlinkGCPluginConsumer.h"
 
 #include <algorithm>
 #include <set>
 
 #include "CheckDispatchVisitor.h"
@@ skipping 50 matching lines @@
 };
 
 }  // namespace
 
 BlinkGCPluginConsumer::BlinkGCPluginConsumer(
     clang::CompilerInstance& instance,
     const BlinkGCPluginOptions& options)
     : instance_(instance),
       reporter_(instance),
       options_(options),
+      cache_(instance),
       json_(0) {
   // Only check structures in the blink and WebKit namespaces.
   options_.checked_namespaces.insert("blink");
 
   // Ignore GC implementation files.
   options_.ignored_directories.push_back("/heap/");
 }
 
 void BlinkGCPluginConsumer::HandleTranslationUnit(ASTContext& context) {
   // Don't run the plugin if the compilation unit is already invalid.
@@ skipping 464 matching lines @@
   // traceImpl (or traceAfterDispatchImpl) method. We will report on
   // CheckTraceMethod on traceImpl method.
   if (visitor.delegates_to_traceimpl())
     return;
 
   for (auto& base : parent->GetBases())
     if (!base.second.IsProperlyTraced())
       reporter_.BaseRequiresTracing(parent, trace, base.first);
 
   for (auto& field : parent->GetFields()) {
-    if (!field.second.IsProperlyTraced()) {
-      // Discontinue once an untraced-field error is found.
-      reporter_.FieldsRequireTracing(parent, trace);
+    if (!field.second.IsProperlyTraced() ||
+        field.second.IsInproperlyTraced()) {
+      // Report one or more tracing-related field errors.
+      reporter_.FieldsImproperlyTraced(parent, trace);
       break;
     }
   }
 }
 
 void BlinkGCPluginConsumer::DumpClass(RecordInfo* info) {
   if (!json_)
     return;
 
   json_->OpenObject();
@@ skipping 15 matching lines @@
       json_->Write("lbl", lbl);
       json_->Write("kind", kind);
       json_->Write("loc", loc);
       json_->Write("ptr",
                    !Parent() ? "val" :
                    Parent()->IsRawPtr() ?
                        (static_cast<RawPtr*>(Parent())->HasReferenceType() ?
                         "reference" : "raw") :
                    Parent()->IsRefPtr() ? "ref" :
                    Parent()->IsOwnPtr() ? "own" :
+                   Parent()->IsUniquePtr() ? "unique" :
                    (Parent()->IsMember() || Parent()->IsWeakMember()) ? "mem" :
                    "val");
       json_->CloseObject();
     }
 
     void DumpField(RecordInfo* src, FieldPoint* point, const std::string& loc) {
       src_ = src;
       point_ = point;
       loc_ = loc;
       point_->edge()->Accept(this);
@@ skipping 109 matching lines @@
   SourceLocation spelling_location = source_manager.getSpellingLoc(loc);
   PresumedLoc ploc = source_manager.getPresumedLoc(spelling_location);
   if (ploc.isInvalid()) {
     // If we're in an invalid location, we're looking at things that aren't
     // actually stated in the source.
     return false;
   }
   *filename = ploc.getFilename();
   return true;
 }