Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2060483003: [ios] Extracted web_test.h classes into separate files. (Closed)

Created:
4 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 6 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Extracted web_test.h classes into separate files. web::WebTest, web::WebTestWithWebStates and web::WebTestWithWebController are now separate classes placed in separate files. Old web_test.h files is kept temporary to switch all downstream files to use new includes. BUG=619076 Committed: https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2 Cr-Commit-Position: refs/heads/master@{#399351}

Patch Set 1 #

Patch Set 2 : Self review #

Patch Set 3 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -469 lines) Patch
M ios/web/BUILD.gn View 1 2 chunks +6 lines, -1 line 0 comments Download
M ios/web/ios_web.gyp View 1 2 chunks +6 lines, -1 line 0 comments Download
A ios/web/public/test/web_test.h View 1 1 chunk +46 lines, -0 lines 0 comments Download
A ios/web/public/test/web_test.mm View 1 1 chunk +35 lines, -0 lines 0 comments Download
A + ios/web/public/test/web_test_with_web_state.h View 1 2 3 chunks +22 lines, -52 lines 0 comments Download
A + ios/web/public/test/web_test_with_web_state.mm View 1 7 chunks +46 lines, -84 lines 0 comments Download
M ios/web/test/web_test.h View 1 chunk +3 lines, -101 lines 0 comments Download
M ios/web/test/web_test.mm View 1 1 chunk +0 lines, -230 lines 0 comments Download
A ios/web/test/web_test_with_web_controller.h View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/web/test/web_test_with_web_controller.mm View 1 chunk +19 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060483003/1
4 years, 6 months ago (2016-06-10 20:40:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060483003/20001
4 years, 6 months ago (2016-06-10 21:29:32 UTC) #4
Eugene But (OOO till 7-30)
4 years, 6 months ago (2016-06-10 21:33:23 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060483003/40001
4 years, 6 months ago (2016-06-10 21:33:56 UTC) #9
kkhorimoto
lgtm
4 years, 6 months ago (2016-06-10 22:55:16 UTC) #10
Eugene But (OOO till 7-30)
Thanks!
4 years, 6 months ago (2016-06-10 22:57:10 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/86146)
4 years, 6 months ago (2016-06-11 00:33:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060483003/40001
4 years, 6 months ago (2016-06-11 00:55:47 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-11 02:10:50 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-11 02:10:52 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-11 02:12:04 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2
Cr-Commit-Position: refs/heads/master@{#399351}

Powered by Google App Engine
This is Rietveld 408576698