Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2060483002: S390: [stubs] Remove N-argument Hydrogen-based Array constructor stub (Closed)

Created:
4 years, 6 months ago by john.yan
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [stubs] Remove N-argument Hydrogen-based Array constructor stub Port c8ac0d8693f559795eeb3f3aaf386dde166fb2ab Original commit message: Instead, always tail call to the runtime. Also, cleanup the various versions of the runtime call that is used for Array construction fallback. There can be only one. R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/d86458b1bc77df97c897743711faa10f3d52a7b7 Cr-Commit-Position: refs/heads/master@{#36904}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -71 lines) Patch
M src/crankshaft/s390/lithium-codegen-s390.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 7 chunks +17 lines, -54 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
john.yan
PTAL
4 years, 6 months ago (2016-06-10 18:36:43 UTC) #1
JaideepBajwa
lgtm
4 years, 6 months ago (2016-06-10 18:39:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060483002/40001
4 years, 6 months ago (2016-06-10 19:17:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-10 19:43:15 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 19:43:54 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d86458b1bc77df97c897743711faa10f3d52a7b7
Cr-Commit-Position: refs/heads/master@{#36904}

Powered by Google App Engine
This is Rietveld 408576698