Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Issue 2060473002: S390: Remove more dead code now that legacy const is gone (Closed)

Created:
4 years, 6 months ago by john.yan
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Remove more dead code now that legacy const is gone Port 757221e574ecba543a65f4822c083aa860e030eb Original commit message: Neither globals nor lookup slots can be hole-initialized anymore, thus removing some dead code from the code generators and runtime-scopes. R=adamk@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/87ccb1d8af4bff4c0147ba9754dd268a0cf1fb7f Cr-Commit-Position: refs/heads/master@{#36902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 6 months ago (2016-06-10 18:36:30 UTC) #1
JaideepBajwa
lgtm
4 years, 6 months ago (2016-06-10 18:40:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060473002/1
4 years, 6 months ago (2016-06-10 18:41:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 19:11:11 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 19:12:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87ccb1d8af4bff4c0147ba9754dd268a0cf1fb7f
Cr-Commit-Position: refs/heads/master@{#36902}

Powered by Google App Engine
This is Rietveld 408576698