Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2060463002: DevTools: allow toValue to accept unique_ptr. (Closed)

Created:
4 years, 6 months ago by pfeldman
Modified:
4 years, 6 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: allow toValue to accept unique_ptr. Committed: https://crrev.com/b8bfb7c0a31c453b81c910c69338311289bd5948 Cr-Commit-Position: refs/heads/master@{#399272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M third_party/WebKit/Source/platform/inspector_protocol/Array.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pfeldman
4 years, 6 months ago (2016-06-10 18:06:16 UTC) #2
alph
lgtm
4 years, 6 months ago (2016-06-10 18:09:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060463002/1
4 years, 6 months ago (2016-06-10 18:36:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 21:33:49 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 21:34:33 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 21:35:12 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b8bfb7c0a31c453b81c910c69338311289bd5948
Cr-Commit-Position: refs/heads/master@{#399272}

Powered by Google App Engine
This is Rietveld 408576698