Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2060443002:
[perf] Prepare benchmarks for memory metric normalization (vol. 2) (Closed)
|
Created:
4 years, 6 months ago by petrcermak Modified:
4 years, 6 months ago Reviewers:
nednguyen CC:
chromium-reviews, telemetry-reviews_chromium.org, ulan Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[perf] Prepare benchmarks for memory metric normalization (vol. 2)
This is patch is necessary so that benchmarks using the memory metric
wouldn't stop reporting values once
https://codereview.chromium.org/2018503002/ lands.
First preparation patch: https://codereview.chromium.org/2044853002/
BUG=617117
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
Committed: https://crrev.com/f5de9f7cef3514f7ec57c554604afd4e9277064f
Cr-Commit-Position: refs/heads/master@{#399422}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 18 (9 generated)
Description was changed from ========== [perf] Prepare benchmarks for memory metric normalization This is patch is necessary so that benchmarks using the memory metric wouldn't stop reporting values once https://codereview.chromium.org/2018503002/ lands. First preparation patch: https://codereview.chromium.org/2044853002/ BUG=617117 ========== to ========== [perf] Prepare benchmarks for memory metric normalization This is patch is necessary so that benchmarks using the memory metric wouldn't stop reporting values once https://codereview.chromium.org/2018503002/ lands. First preparation patch: https://codereview.chromium.org/2044853002/ BUG=617117 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
petrcermak@chromium.org changed reviewers: + nednguyen@google.com
PTAL. Thanks, Petr
Description was changed from ========== [perf] Prepare benchmarks for memory metric normalization This is patch is necessary so that benchmarks using the memory metric wouldn't stop reporting values once https://codereview.chromium.org/2018503002/ lands. First preparation patch: https://codereview.chromium.org/2044853002/ BUG=617117 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Prepare benchmarks for memory metric normalization (vol. 2) This is patch is necessary so that benchmarks using the memory metric wouldn't stop reporting values once https://codereview.chromium.org/2018503002/ lands. First preparation patch: https://codereview.chromium.org/2044853002/ BUG=617117 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
lgtm
https://codereview.chromium.org/2060443002/diff/1/tools/perf/benchmarks/memor... File tools/perf/benchmarks/memory_infra.py (right): https://codereview.chromium.org/2060443002/diff/1/tools/perf/benchmarks/memor... tools/perf/benchmarks/memory_infra.py:169: r'renderer_processes:' Don't you need (renderer_processes:|renderer:) so this matches the old name too?
https://codereview.chromium.org/2060443002/diff/1/tools/perf/benchmarks/memor... File tools/perf/benchmarks/memory_infra.py (right): https://codereview.chromium.org/2060443002/diff/1/tools/perf/benchmarks/memor... tools/perf/benchmarks/memory_infra.py:169: r'renderer_processes:' On 2016/06/11 04:46:58, nednguyen wrote: > Don't you need (renderer_processes:|renderer:) so this matches the old name too? No, but thanks for checking :-) This change only applies to the new names. The old names are checked on lines 188 and 189 (to be removed after normalization).
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060443002/1
Description was changed from ========== [perf] Prepare benchmarks for memory metric normalization (vol. 2) This is patch is necessary so that benchmarks using the memory metric wouldn't stop reporting values once https://codereview.chromium.org/2018503002/ lands. First preparation patch: https://codereview.chromium.org/2044853002/ BUG=617117 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Prepare benchmarks for memory metric normalization (vol. 2) This is patch is necessary so that benchmarks using the memory metric wouldn't stop reporting values once https://codereview.chromium.org/2018503002/ lands. First preparation patch: https://codereview.chromium.org/2044853002/ BUG=617117 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
The CQ bit was unchecked by petrcermak@chromium.org
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060443002/1
Message was sent while issue was closed.
Description was changed from ========== [perf] Prepare benchmarks for memory metric normalization (vol. 2) This is patch is necessary so that benchmarks using the memory metric wouldn't stop reporting values once https://codereview.chromium.org/2018503002/ lands. First preparation patch: https://codereview.chromium.org/2044853002/ BUG=617117 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Prepare benchmarks for memory metric normalization (vol. 2) This is patch is necessary so that benchmarks using the memory metric wouldn't stop reporting values once https://codereview.chromium.org/2018503002/ lands. First preparation patch: https://codereview.chromium.org/2044853002/ BUG=617117 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== [perf] Prepare benchmarks for memory metric normalization (vol. 2) This is patch is necessary so that benchmarks using the memory metric wouldn't stop reporting values once https://codereview.chromium.org/2018503002/ lands. First preparation patch: https://codereview.chromium.org/2044853002/ BUG=617117 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Prepare benchmarks for memory metric normalization (vol. 2) This is patch is necessary so that benchmarks using the memory metric wouldn't stop reporting values once https://codereview.chromium.org/2018503002/ lands. First preparation patch: https://codereview.chromium.org/2044853002/ BUG=617117 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/f5de9f7cef3514f7ec57c554604afd4e9277064f Cr-Commit-Position: refs/heads/master@{#399422} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f5de9f7cef3514f7ec57c554604afd4e9277064f Cr-Commit-Position: refs/heads/master@{#399422} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
