Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 2060433004: [Media Router] Close dialog after resolving presentation request (Closed)

Created:
4 years, 6 months ago by imcheng
Modified:
4 years, 6 months ago
Reviewers:
imcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Media Router] Close dialog after resolving presentation request This change causes the Media Router dialog to close after it resolves a route that is from a presentation request. This prevents the dialog from staying open (by the user keeping their mouse over it) and reusing the same presentation request for another route request (which is an error). BUG=617321 R=imcheng@chromium.org Review-Url: https://codereview.chromium.org/2038423006 Cr-Commit-Position: refs/heads/master@{#398683} (cherry picked from commit cbe9df4959c78e3d8a4fbaa1fef5ccde9b4c0f3f) Committed: https://chromium.googlesource.com/chromium/src/+/827411a04371fcaefd879fbc7e13061a232f1cea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M chrome/browser/ui/webui/media_router/media_router_ui.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.cc View 3 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
imcheng
4 years, 6 months ago (2016-06-11 16:47:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
827411a04371fcaefd879fbc7e13061a232f1cea.

Powered by Google App Engine
This is Rietveld 408576698