Optimize paths comparision in source closure sorting.

Optimize paths comparision in source closure sorting.

This makes incremental analysis 13% faster.
Paths comparision time falls from 12.9% to 3.2%.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/8b2d313300e79af02809f2c0da78aa8498951e80

[Brian Wilkerson, 2016-06-10 21:19:13]

lgtm

https://codereview.chromium.org/2060433003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/incremental_cache.dart (right):

https://codereview.chromium.org/2060433003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/incremental_cache.dart:47: if (thisLength <
otherLength) {
Couldn't these length tests come before the character comparisons (before the
'for')?

[Brian Wilkerson, 2016-06-10 21:20:11]

https://codereview.chromium.org/2060433003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/incremental_cache.dart (right):

https://codereview.chromium.org/2060433003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/incremental_cache.dart:47: if (thisLength <
otherLength) {
Nevermind, I realized why not as I clicked "send".

[scheglov, 2016-06-10 21:26:43]

Description was changed from

==========
Optimize paths comparision in source closure sorting.

This makes incremental analysis 13% faster.
Paths comparision time falls from 12.9% to 3.2%.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Optimize paths comparision in source closure sorting.

This makes incremental analysis 13% faster.
Paths comparision time falls from 12.9% to 3.2%.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/8b2d313300e79af02809f2c0da78aa8498951e80
==========

[scheglov, 2016-06-10 21:26:45]

Committed patchset #1 (id:1) manually as
8b2d313300e79af02809f2c0da78aa8498951e80 (presubmit successful).