Chromium Code Reviews

Issue 2060433002: Move SourceRange and CSSPropertySourceData classes off-heap. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, haraken, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, blink-reviews-css, devtools-reviews_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SourceRange and CSSPropertySourceData classes off-heap. SourceRange is a value/POD class that has no complex sharing or lifetime handling associated with it. It does not meet minimal requirements that we've now settled on for when an object ought to be Oilpan managed -- doesn't have other heap references nor sharing&lifetime issues that would benefit from Oilpan use -- hence, we should move it off-heap. With SourceRange off-heap, a number of classes that package up SourceRanges in various ways can be converted to off-heap classes also. R= BUG= Committed: https://crrev.com/76d48b679c0f977b5ba276e28e24d4b820d6bd73 Cr-Commit-Position: refs/heads/master@{#399428}

Patch Set 1 #

Patch Set 2 : fix untidy ref-ptr handling #

Unified diffs Side-by-side diffs Stats (+111 lines, -130 lines)
M third_party/WebKit/Source/core/css/CSSPropertySourceData.h View 5 chunks +41 lines, -55 lines 0 comments
M third_party/WebKit/Source/core/css/CSSPropertySourceData.cpp View 1 chunk +0 lines, -10 lines 0 comments
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 3 chunks +3 lines, -3 lines 0 comments
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.h View 4 chunks +8 lines, -7 lines 0 comments
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 32 chunks +59 lines, -55 lines 0 comments

Messages

Total messages: 15 (7 generated)
sof
please take a look. afaict, SourceRange is the one remaining POD type that's on the ...
4 years, 6 months ago (2016-06-12 18:19:53 UTC) #3
haraken
LGTM
4 years, 6 months ago (2016-06-13 00:47:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060433002/20001
4 years, 6 months ago (2016-06-13 09:25:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/162134)
4 years, 6 months ago (2016-06-13 10:17:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060433002/20001
4 years, 6 months ago (2016-06-13 10:37:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 11:04:19 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 11:04:21 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 11:05:46 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76d48b679c0f977b5ba276e28e24d4b820d6bd73
Cr-Commit-Position: refs/heads/master@{#399428}

Powered by Google App Engine