Issue 206041: Some history backend fixes for database corruption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206041: Some history backend fixes for database corruption. (Closed)

Created:
11 years, 3 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, cpu_(ooo_6.6-7.5)

Visibility:
Public.

Description

Some history backend fixes for database corruption. Don't enter an infinite loop in GetLastSegmentID() when traversing the referring_visit list. Don't return rows from visits table where a specific visit_id was passed but some other visit_id was returned. Don't update visits table with rows who's referring_visit refers to the visit itself. BUGS=20321 TEST=Don't hang with Kelly's profile. I guess Kelly could test? [git cl dcommit messed up. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision= 26513 ]

Patch Set 1 #

Patch Set 2 : Update to use a set to track bigger referer loops. #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	chrome/browser/history/history_backend.cc	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download
	M	chrome/browser/history/visit_database.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

I am not entirely convinced that this is right. The DCHECKs keep firing, making me ...

11 years, 3 months ago (2009-09-16 22:16:11 UTC) #1

LGTM

Expand Messages | Collapse Messages