Issue 206040: Add test for history HTML escaping issue....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206040: Add test for history HTML escaping issue.... (Closed)

Created:
11 years, 3 months ago by Chris Evans

Modified:
9 years, 6 months ago

Reviewers:
Miranda Callahan, abarth-chromium

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add test for history HTML escaping issue. BUG=17892 TEST=SessionHistoryTest.HistorySearchXSS Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26392

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	chrome/browser/session_history_uitest.cc	View		2 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

This LGTM, but you might want to give Miranda a chance to comment.

11 years, 3 months ago (2009-09-16 21:15:10 UTC) #2

Miranda Callahan

11 years, 3 months ago (2009-09-16 21:16:56 UTC) #3

Definitely LGTM, and very helpful, thanks!

On 2009/09/16 21:15:10, abarth wrote:
> This LGTM, but you might want to give Miranda a chance to comment.

Expand Messages | Collapse Messages