Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2060353005: Convert video-autoplay*, video-black* and video-buffered* tests to testharness.js (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 6 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-autoplay*, video-black* and video-buffered* tests to testharness.js Cleaning up video-autoplay*, video-black* and video-buffered* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/fe0fd98eb20daec3e6dfb536118ecb761e2b5da9 Cr-Commit-Position: refs/heads/master@{#399844}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address nit #

Messages

Total messages: 16 (8 generated)
Srirama
PTAL
4 years, 6 months ago (2016-06-14 15:14:35 UTC) #3
fs
LGTM w/ nit https://codereview.chromium.org/2060353005/diff/1/third_party/WebKit/LayoutTests/media/video-black-bg-in-media-document.html File third_party/WebKit/LayoutTests/media/video-black-bg-in-media-document.html (right): https://codereview.chromium.org/2060353005/diff/1/third_party/WebKit/LayoutTests/media/video-black-bg-in-media-document.html#newcode14 third_party/WebKit/LayoutTests/media/video-black-bg-in-media-document.html:14: // Required to be global for ...
4 years, 6 months ago (2016-06-14 15:41:37 UTC) #4
Srirama
https://codereview.chromium.org/2060353005/diff/1/third_party/WebKit/LayoutTests/media/video-black-bg-in-media-document.html File third_party/WebKit/LayoutTests/media/video-black-bg-in-media-document.html (right): https://codereview.chromium.org/2060353005/diff/1/third_party/WebKit/LayoutTests/media/video-black-bg-in-media-document.html#newcode14 third_party/WebKit/LayoutTests/media/video-black-bg-in-media-document.html:14: // Required to be global for assert_equals() to work ...
4 years, 6 months ago (2016-06-14 16:04:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060353005/20001
4 years, 6 months ago (2016-06-14 16:05:13 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/238801)
4 years, 6 months ago (2016-06-14 18:21:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060353005/20001
4 years, 6 months ago (2016-06-15 03:41:37 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-15 04:59:01 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 05:01:00 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe0fd98eb20daec3e6dfb536118ecb761e2b5da9
Cr-Commit-Position: refs/heads/master@{#399844}

Powered by Google App Engine
This is Rietveld 408576698