Blacklist once.unicornmedia.com from Spitzer playback on Android.

Blacklist once.unicornmedia.com from Spitzer playback on Android.

This domain uses HLS but does not have any identifiers within the
pre-redirect url to indicate that it is HLS. The easiest solution
is to blacklist this domain until we support HLS in WMPI; per UMA
the pre-redirect approach is accurate 99.89%, so it seems prudent
to avoid cruftier workarounds like http://crrev.com/2046253002.

The only other alternative would be building a WebMediaPlayer shim
that can dynamically switch between WMPI and WMPA, such an effort
would have a lot of rough edges since it would need to save and
propogate all state which occurs between when load() starts and
the actual WebMediaPlayer is selected.

BUG=618109, 619729
TEST=manual, http://espn.go.com/ plays on mobile.

[DaleCurtis, 2016-06-13 22:36:53]

dalecurtis@chromium.org changed reviewers:
+ nick@chromium.org

[DaleCurtis, 2016-06-13 22:36:54]

This is not ideal, but the alternatives are cruftier. WDYT?

[DaleCurtis, 2016-06-13 22:37:32]

Description was changed from

==========
Blacklist once.unicornmedia.com from Spitzer playback on Android.

This domain uses HLS but does not have any identifiers within the
pre-redirect url to indicate that it is HLS. The easiest solution
is to blacklist this domain until we support HLS in WMPI; per UMA
the pre-redirect approach is accurate 99.89%, so it seems prudent
to avoid cruftier workarounds like http://crrev.com/2046253002.

The only other alternative would be building a WebMediaPlayer shim
that can dynamically switch between WMPI and WMPA, such an effort
would have a lot of rough edges since it would need to save and
propogate all state which occurs between when load() starts and
the actual WebMediaPlayer is selected.

BUG=618109
TEST=manual, http://espn.go.com/ plays on mobile.
==========

to

==========
Blacklist once.unicornmedia.com from Spitzer playback on Android.

This domain uses HLS but does not have any identifiers within the
pre-redirect url to indicate that it is HLS. The easiest solution
is to blacklist this domain until we support HLS in WMPI; per UMA
the pre-redirect approach is accurate 99.89%, so it seems prudent
to avoid cruftier workarounds like http://crrev.com/2046253002.

The only other alternative would be building a WebMediaPlayer shim
that can dynamically switch between WMPI and WMPA, such an effort
would have a lot of rough edges since it would need to save and
propogate all state which occurs between when load() starts and
the actual WebMediaPlayer is selected.

BUG=618109, 619729
TEST=manual, http://espn.go.com/ plays on mobile.
==========

[ncarter (slow), 2016-06-13 23:19:04]

https://codereview.chromium.org/2060353004/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2060353004/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:836: if
(url.DomainIs("once.unicornmedia.com"))
My gut reaction is that this is too hacky to approve. A web browser shouldn't
have any hardcoded references to particular sites like this.

[DaleCurtis, 2016-06-13 23:25:47]

I agree it's terrible, I'll get philipj@'s opinion on the blink version.

https://codereview.chromium.org/2060353004/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2060353004/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:836: if
(url.DomainIs("once.unicornmedia.com"))
On 2016/06/13 at 23:19:04, ncarter (at blinkon til 20JUN) wrote:
> My gut reaction is that this is too hacky to approve. A web browser shouldn't
have any hardcoded references to particular sites like this.

Does your opinion change if you think of this more as an experimental opt-out
for the new path?