components/cronet/tools/cr_cronet.py - Issue 2060333002: [Cronet] Enforce ARMv7 Cronet doesn't inadvertently use ARM Neon instructions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/tools/cr_cronet.py

Issue 2060333002: [Cronet] Enforce ARMv7 Cronet doesn't inadvertently use ARM Neon instructions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/cronet/tools/cr_cronet.py

diff --git a/components/cronet/tools/cr_cronet.py b/components/cronet/tools/cr_cronet.py

index 75cc5ea4d6a6a87e4b5aca8817a030b673757692..940e93514b5ca79884e1ea6b549fc5a94a8997de 100755

--- a/components/cronet/tools/cr_cronet.py

+++ b/components/cronet/tools/cr_cronet.py

@@ -95,11 +95,11 @@ def main():

gyp_defines = 'GYP_DEFINES="OS=' + target_os + ' enable_websockets=0 '+ \

'disable_file_support=1 disable_ftp_support=1 '+ \

'enable_errorprone=1 use_platform_icu_alternatives=1 ' + \

- 'disable_brotli_filter=1"'

+ 'disable_brotli_filter=1 arm_neon=0"'

gn_args += 'target_os="' + target_os + '" enable_websockets=false '+ \

'disable_file_support=true disable_ftp_support=true '+ \

'use_platform_icu_alternatives=true '+ \

- 'disable_brotli_filter=true is_component_build=false'

+ 'disable_brotli_filter=true is_component_build=false arm_use_neon=false'

extra_options = ' '.join(extra_options_list)

if options.gn:

« no previous file with comments | « components/cronet/tools/check_no_neon.py ('k') | tools/mb/mb_config.pyl » ('j') | no next file with comments »