Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: components/cronet/tools/enforce_no_neon.py

Issue 2060333002: [Cronet] Enforce ARMv7 Cronet doesn't inadvertently use ARM Neon instructions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/cronet/android/BUILD.gn ('K') | « components/cronet/tools/cr_cronet.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/tools/enforce_no_neon.py
diff --git a/components/cronet/tools/enforce_no_neon.py b/components/cronet/tools/enforce_no_neon.py
new file mode 100755
index 0000000000000000000000000000000000000000..2cc51b9c1d49e51234e69793b1dde01c492d6bca
--- /dev/null
+++ b/components/cronet/tools/enforce_no_neon.py
@@ -0,0 +1,23 @@
+#!/usr/bin/python
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""
+enforce_no_neon.py - Enforce modules do not contain ARM Neon instructions.
+"""
+
+import os
+import sys
+
+def main():
+ if len(sys.argv) != 3:
+ print 'Usage: ' + os.path.basename(sys.argv[0]) + \
+ ' path/to/ARM/toolchain files/to/check/*.o'
+ return 1
+ return os.system(os.path.join(sys.argv[1], 'bin',
+ 'arm-linux-androideabi-objdump') + ' -d --no-show-raw-insn ' +
+ sys.argv[2] + ' | grep -q "vld[1-9]\\|vst[1-9]"')
mef 2016/06/24 20:18:08 ls vld and vst sprinkled all over base if neon is
pauljensen 2016/06/27 12:58:42 Yes. I think they're used for things like initial
+
+if __name__ == '__main__':
+ sys.exit(0 if main() != 0 else -1)
« components/cronet/android/BUILD.gn ('K') | « components/cronet/tools/cr_cronet.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698