Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: components/cronet/android/BUILD.gn

Issue 2060333002: [Cronet] Enforce ARMv7 Cronet doesn't inadvertently use ARM Neon instructions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: redo objdump path Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/rules.gni") 7 import("//build/config/android/rules.gni")
8 import("//build/util/version.gni") 8 import("//build/util/version.gni")
9 import("//chrome/version.gni") 9 import("//chrome/version.gni")
10 import("//testing/test.gni") 10 import("//testing/test.gni")
(...skipping 806 matching lines...) Expand 10 before | Expand all | Expand 10 after
817 rebase_path(depfile, root_build_dir), 817 rebase_path(depfile, root_build_dir),
818 "--lib-java-dir", 818 "--lib-java-dir",
819 rebase_path("$root_build_dir/lib.java/components/cronet/android", 819 rebase_path("$root_build_dir/lib.java/components/cronet/android",
820 root_build_dir), 820 root_build_dir),
821 ] 821 ]
822 deps = [ 822 deps = [
823 ":cronet_javadoc_classpath", 823 ":cronet_javadoc_classpath",
824 ] 824 ]
825 } 825 }
826 826
827 action("enforce_no_neon") {
828 script = "//components/cronet/tools/enforce_no_neon.py"
829 args = [
830 rebase_path("${android_tool_prefix}objdump", root_build_dir),
831
832 # libcronet.so may contain ARM Neon instructions from BoringSSL, but these
833 # are only used after checking whether the CPU supports NEON at runtime,
834 # so instead check base/ as it represents a large swath of code that only
835 # contains Neon instructions when Neon is enabled by default.
836 rebase_path("$root_out_dir/obj/base/base/*.o", root_build_dir),
837 ]
838 outputs = [
839 "$root_out_dir/cronet_$target_name.d",
840 ]
841 deps = [
842 "//base:base",
843 ]
844 }
845
827 copy("cronet_package_copy") { 846 copy("cronet_package_copy") {
828 sources = [ 847 sources = [
829 "$root_out_dir/lib.java/components/cronet/android/cronet_api.jar", 848 "$root_out_dir/lib.java/components/cronet/android/cronet_api.jar",
830 "//AUTHORS", 849 "//AUTHORS",
831 "//chrome/VERSION", 850 "//chrome/VERSION",
832 "//components/cronet/android/proguard.cfg", 851 "//components/cronet/android/proguard.cfg",
833 ] 852 ]
834 outputs = [ 853 outputs = [
835 "$_package_dir/{{source_file_part}}", 854 "$_package_dir/{{source_file_part}}",
836 ] 855 ]
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
869 ":cronet_package_copy", 888 ":cronet_package_copy",
870 ":cronet_package_copy_native_lib", 889 ":cronet_package_copy_native_lib",
871 ":cronet_package_copy_native_lib_unstripped", 890 ":cronet_package_copy_native_lib_unstripped",
872 ":generate_javadoc", 891 ":generate_javadoc",
873 ":generate_licenses", 892 ":generate_licenses",
874 ":jar_cronet_api_source", 893 ":jar_cronet_api_source",
875 ":jar_cronet_other_source", 894 ":jar_cronet_other_source",
876 ":jar_cronet_sample_source", 895 ":jar_cronet_sample_source",
877 ":repackage_extracted_jars", 896 ":repackage_extracted_jars",
878 ] 897 ]
898 if (current_cpu == "armv7" || current_cpu == "arm") {
899 deps += [ ":enforce_no_neon" ]
900 }
879 } 901 }
OLDNEW
« no previous file with comments | « no previous file | components/cronet/tools/cr_cronet.py » ('j') | components/cronet/tools/enforce_no_neon.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698