[Cronet] Enforce ARMv7 Cronet doesn't inadvertently use ARM Neon instructions

components/cronet/tools/check_no_neon.py

+#!/usr/bin/python
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""
+check_no_neon.py - Check modules do not contain ARM Neon instructions.
+"""

[Dirk Pranke, 2016/08/18 17:10:38]

nit: this can probably be a single line.

[pauljensen, 2016/08/19 11:52:05]

Done.

+
+import argparse
+import os
+import sys
+
+def main(args):

[Dirk Pranke, 2016/08/18 17:10:38]

nit: two blank lines.

[pauljensen, 2016/08/19 11:52:05]

Done.

+  parser = argparse.ArgumentParser(
+      description='Check modules do not contain ARM Neon instructions.')
+  parser.add_argument('objdump', metavar='path/to/ARM/objdump')
+  parser.add_argument('objects', metavar='files/to/check/*.o')
+  opts = parser.parse_args(args)
+  return os.system(opts.objdump + ' -d --no-show-raw-insn ' +
+      opts.objects + ' | grep -q "vld[1-9]\\|vst[1-9]"')
+
+if __name__ == '__main__':

[Dirk Pranke, 2016/08/18 17:10:38]

two blank lines.

[pauljensen, 2016/08/19 11:52:05]

Done.

+  sys.exit(0 if main(sys.argv[1:]) != 0 else -1)