[Cronet] Enforce ARMv7 Cronet doesn't inadvertently use ARM Neon instructions

tools/mb/mb_config.pyl

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   # This is a map of buildbot master names -> buildbot builder names ->
   # config names (where each config name is a key in the 'configs' dict,
   # below). MB uses this dict to look up which config to use for a given bot.
   'masters': {
     # Take care when changing any of these builders to ensure that you do not
@@ skipping 916 matching lines @@
       'debug_trybot',
     ],
 
     'android_clang_tot_asan': [
       'android_without_codecs', 'clang_tot', 'asan', 'gn',
       'shared', 'debug', 'minimal_symbols',
     ],
 
     'android_cronet_data_reduction_proxy_gn_release_bot_minimal_symbols': [
       'android', 'cronet', 'data_reduction_proxy', 'gn',
-      'release_bot_minimal_symbols', 'arm'
+      'release_bot_minimal_symbols', 'arm_no_neon'
     ],
 
     'android_cronet_gn_debug_static_bot': [
-      'android', 'cronet', 'gn', 'debug_static_bot', 'arm'
+      'android', 'cronet', 'gn', 'debug_static_bot', 'arm_no_neon'
     ],
 
     'android_cronet_gn_debug_static_bot_arm64': [
       'android', 'cronet', 'gn', 'debug_static_bot', 'arm64'
     ],
 
     'android_cronet_gn_debug_static_bot_x86': [
       'android', 'cronet', 'gn', 'debug_static_bot', 'x86'
     ],
 
     'android_cronet_gn_release_bot_minimal_symbols': [
-      'android', 'cronet', 'gn', 'release_bot_minimal_symbols', 'arm'
+      'android', 'cronet', 'gn', 'release_bot_minimal_symbols', 'arm_no_neon'
     ],
 
     'android_cronet_gn_release_bot_minimal_symbols_arm64': [
       'android', 'cronet', 'gn', 'release_bot_minimal_symbols', 'arm64'
     ],
 
     'android_cronet_gn_release_bot_minimal_symbols_armv6': [
       'android', 'cronet', 'gn', 'release_bot_minimal_symbols', 'armv6'
     ],
 
     'android_cronet_gn_release_bot_minimal_symbols_clang_asan': [
-      'android', 'cronet', 'gn', 'release_bot_minimal_symbols', 'arm', 'clang',
-      'asan'
+      'android', 'cronet', 'gn', 'release_bot_minimal_symbols', 'arm_no_neon',
+      'clang', 'asan'
     ],
 
     'android_cronet_gn_release_bot_minimal_symbols_mipsel': [
       'android', 'cronet', 'gn', 'release_bot_minimal_symbols', 'mipsel'
     ],
 
     'android_cronet_gn_release_bot_minimal_symbols_x86': [
       'android', 'cronet', 'gn', 'release_bot_minimal_symbols', 'x86'
     ],
 
@@ skipping 912 matching lines @@
     'angle_deqp_tests': {
       'gyp_defines': 'build_angle_deqp_tests=1',
       'gn_args': 'build_angle_deqp_tests=true',
     },
 
     'arm': {
       'gn_args': 'target_cpu="arm"',
       'gyp_defines': 'target_arch=arm',
     },
 
+    'arm_no_neon': {
+      'gn_args': 'target_cpu="arm" arm_use_neon=false',

[jbudorick, 2016/07/19 18:49:16]

I don't think this should duplicate the arm parameters. You might be able to do
something like this, though:

  'arm_no_neon': {
    'mixins': ['arm'],
    'gn_args': 'arm_use_neon=false',
    'gyp_defines': 'arm_neon=0',
  },

That may not work, or it may not be recommended style, so you could also do

  'no_neon': {
    'gn_args': 'arm_use_neon=false',
    'gyp_defines': 'arm_neon=0',
  },

  'arm_no_neon': {
    'mixins': ['arm', 'no_neon'],
  },

[pauljensen, 2016/07/20 15:04:38]

Done.

+      'gyp_defines': 'target_arch=arm arm_neon=0',
+    },
+
     'arm64': {
       'gn_args': 'target_cpu="arm64"',
       'gyp_defines': 'target_arch=arm64',
     },
 
     'armv6': {
       'gn_args': 'arm_version=6',
       'gyp_defines': 'arm_version=6',
     },
 
@@ skipping 403 matching lines @@
     },
 
     'drfuzz': { 'gn_args': 'use_drfuzz=true' },
 
     'drmemory': {
       'gn_args': 'is_component_build=true enable_iterator_debugging=false',
       'gyp_defines': 'component=shared_library build_for_tool=drmemory',
     },
   },
 }